1703073 - Firefox crash when adding bookmark while location popup is open

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P1)

Description

[Sam Bull]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:87.0) Gecko/20100101 Firefox/87.0

Steps to reproduce:

View: https://palegreendot.co.uk/collections/fresh-alcohol-fortnightly/products/premium-veg-box-fortnightly-subscription?selling_plan=441122970&variant=37737131016346

A location permission popup appears.
While this popup is still open, click the button to bookmark a page.

Actual results:

The star turns blue to confirm the bookmark, but nothing else happens. The browser completely freezes (prompting a 'Firefox is not responding' dialog), or just crashes.

Comment 1

[Sam Bull]

@stransky I'm using Wayland, so this could be a Wayland-specific issue.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[Timea Cernea [:tbabos][inactive]]

Hi Sam,
I was unable to reproduce this on Windows 10 but as you also mentioned this could be a Wayland specific issue.
Can you please share here the crash reports you have? To do that, please navigate to about:crashes, submit any available crashes after reproducing it and share it here.
Moving this over to the wayland specific component in the meantime. Thanks!

Comment 4

[Timea Cernea [:tbabos][inactive]]

Forgot to NI?

Comment 5

[Sam Bull]

Most recent crash report is from 14th January, seems that these crashes are not getting logged (I've had plenty of crashes recently due to OOM problems, and it looks they are not here either).

Comment 6

[Martin Stránský [:stransky] (ni? me)]

This is caused by Wayland architecture. Generally when we hide any popup in popup chain we need to hide/reposition all child popups. It also affects all popup operations at nsWindow::NativeMoveResizeWaylandPopup() where popup is hidden/shown due to https://gitlab.gnome.org/GNOME/gtk/issues/1986

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1703073 [Wayland] Rework Wayland popup hierarchy management, r?jhorak

• Keep strong popup hierarchy from both layout and widget perspective and use only
  topmost popups as parents for newly opened popups.
• Always close popup windows with all opened child popups.
• Always close tooltip windows when new popup is created.
• Introduce 'WidgetPopup' log to trace popups changes.
• Export correct window roles (Toplevel, Popup, Dialog).

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72bdd02e4155
[Wayland] Rework Wayland popup hierarchy management, r=jhorak

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/72bdd02e4155