Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser/base/content/test/popupNotifications/head.js
Categories
(Firefox :: General, task, P5)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | fixed |
People
(Reporter: prathiksha, Assigned: mbansal, Mentored)
Details
Attachments
(1 file)
This is a good first bug for newcomers to Firefox development.
BrowserTestUtils.waitForCondition in browser/base/content/test/popupNotifications/head.js[0] can be replaced with TestUtils.waitForCondition.
You can run tests with the ./mach test command:
./mach test browser/base/content/test/popupNotifications/
Please leave a comment if you would like to be assigned to this bug.
[0] https://searchfox.org/mozilla-central/source/browser/base/content/test/popupNotifications/head.js
|
Reporter | |
Updated•3 years ago
|
I have submitted a patch.
Please have a look @prathiksha.
Also, I had a general query regarding submitting a patch.
In general, we create a branch in git and make changes in that branch. But here I followed these steps:
->hg checkout central
->made changes
->hg commit -m "..."
->moz-phab submit.
Am I going in the right direction?
|
||
Updated•3 years ago
|
Pushed by prathikshaprasadsuman@gmail.com: https://hg.mozilla.org/integration/autoland/rev/8036c8d88c3c Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser/base/content/test/popupNotifications/head.js. r=prathiksha
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
Description
•