1703144 - Get rid of `MOZ_KnownLive` for `EditorBase::SelectionRefPtr()`

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Since bug 1691515 is landed, we can mark member method result as its lifetime is guaranteed. EditorBase::SelectionRefPtr() returns Selection grabbed by AutoEditActionDataSetter which is firstly put on the stack at editor starting to handle anything. Therefore, we can get rid of MOZ_KnownLive(SelectionRefPtr()) etc.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1703144 - Get rid of `MOZ_KnownLive` for `EditorBase::SelectionRefPtr()` r=m_kato!

The lifetime of it is guaranteed by AutoEditActionDataSetter which grabs
Selection until it's destroyed, and it's a stack only class and created
at first step of all public method calls. Therefore, we can mark it as
MOZ_KNOWN_LIVE and we can change it returning reference of Selection
instead of reference of RefPtr<Selection>.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/724cb7aaa828
Get rid of `MOZ_KnownLive` for `EditorBase::SelectionRefPtr()` r=m_kato

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/724cb7aaa828