1703181 - Migrate HelperThreadPool to TaskController

Status: RESOLVED FIXED

(Core :: XPCOM, task, P3)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

HelperThreadPool will dispatch tasks to nsThreadPool, however, nsThreadPool cannot process tasks dispatched during shutdown.
We should try to dispatch tasks to TaskController.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1703181 - Part 1: Remove HelperThreadPool.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1703181 - Part 2: Dispatch to TaskController. ,

We also call setHelperThreadTaskCallback earlier, now it's done in
XPCJSContext::Initialize. So GlobalHelperThreadState could know earlier
if we're dispatching to a external thread pool.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f552efcd43a9
Part 1: Remove HelperThreadPool. r=KrisWright
https://hg.mozilla.org/integration/autoland/rev/f4788d23a4da
Part 2: Dispatch to TaskController. , r=KrisWright

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/f552efcd43a9
https://hg.mozilla.org/mozilla-central/rev/f4788d23a4da