1703201 - Config stack size for JS tasks dispatched to TaskController

Status: RESOLVED DUPLICATE of bug 1716940

(Core :: XPCOM, task, P3)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

For JS helper threads, it uses 2MB as the stack size
https://searchfox.org/mozilla-central/rev/d7e344e956d9da2808ea33e1fe0f963ed10c142d/js/src/vm/HelperThreads.cpp#481
(This is done in https://hg.mozilla.org/mozilla-central/rev/d8df66c4a407)

And TaskController now uses only 512KB
https://searchfox.org/mozilla-central/rev/d7e344e956d9da2808ea33e1fe0f963ed10c142d/xpcom/threads/TaskController.cpp#161

Once we start dispatching JS tasks to TaskController, we should consider enlarging the stack size for JS tasks.

Comment 1

[Jon Coppeard (:jonco)]

The stack limit of 2MB was set in bug 1172895 due to crashes when parsing a long chains of if-else statements. Interestingly a further patch in that bug changed the parsing of these statements to use constant stack space, so we might not need the higher limit after all.

I think we should try using the existing lower limit and increase it if we hit parsing problems.

Comment 2

[Jon Coppeard (:jonco)]

The stack size was increased in bug 1716940.