1703244 - Flush async updates during WebRenderLayerManager::ClearCachedResources

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

There may be async updates queued for the layer manager when we call WebRenderLayerManager::ClearCachedResources. This could be an animated image updating its next frame when the user switches tabs. Currently this can cause an entry to be added to the critical log because we end up deleting the animated image key before the update is applied and the resource update fails. It is better to flush the update first, before clearing, which should largely be a no-op since we are already clearing the display list itself.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

STR:

1. Open https://www.reddit.com, wait for the page to finish loading.
2. Open a new tab, go to about:support and observe the missing "Updating unknown shared surface" entry in the critical log.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1703244 - Flush pending async resource updates when clearing layer manager cache.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6df772b29a9d
Flush pending async resource updates when clearing layer manager cache. r=jrmuizel

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/6df772b29a9d

Comment 5

[Giorgia Nichita, Release Desktop QA]

I'm trying to reproduce the issue following the mentioned steps but I'm having trouble getting to the described result. Can you please provide more information?
I mention that I can't find the "Updating unknown shared surface" entry in the latest Nightly either.