Closed
Bug 1703275
Opened 3 years ago
Closed 3 years ago
Use similar signature for test helpers selectNodeInFrames & getNodeFrontInFrame
Categories
(DevTools :: Inspector, task, P3)
DevTools
Inspector
Tracking
(firefox89 fixed)
RESOLVED
FIXED
89 Branch
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(1 file)
We have two helpers in inspector tests to deal with nodes in (remote) frames:
- selectNodeInFrames (definition)
- getNodeFrontInFrame (definition)
They share a similar implementation, but with confusingly different arguments.
selectNodeInFrames expects an array of selectors: [frame1Selector, frame2Selector, ..., node selector].
getNodeFrontInFrame expects first a node selector, and then a frame selector (and also only supports a single depth).
We should use the same API and they should share their implementation.
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3b34c0afc220 [devtools] Share implementation for inspector test helpers selectNodeInFrames & getNodeFrontInFrame r=nchevobbe
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox89:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•