Closed Bug 1703337 Opened 4 years ago Closed 4 years ago

Position of find bar close button should follow OS behavior

Categories

(Toolkit :: Find Toolbar, defect, P2)

Product:
Toolkit
Component:
Find Toolbar
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox87 --- unaffected
firefox88 --- unaffected
firefox89 --- verified

People

(Reporter: emmamalysz, Assigned: emmamalysz)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [proton-infobars] [priority:2a])

Attachments

(1 file)

Bug 1703337, adjust findbar close button position
48 bytes, text/x-phabricator-request
Details | Review

We are now going to honor the OS when positioning the findbar's close button.
In 1690334, we had moved it to always be on the left. It should be on the right for Windows and Linux.

I'd suggest a P2 priority

Blocks: proton-infobars
Whiteboard: [proton-infobars]
Priority: -- → P2
Whiteboard: [proton-infobars] → [proton-infobars] [priority:2a]

Set release status flags based on info from the regressing bug 1690334

status-firefox87: --- → unaffected
status-firefox88: --- → unaffected
status-firefox89: --- → affected
status-firefox-esr78: --- → unaffected
Assignee: nobody → emalysz
Status: NEW → ASSIGNED
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/80d6228681ee adjust findbar close button position r=mstriemer

https://hg.mozilla.org/mozilla-central/rev/80d6228681ee

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox89: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

Verified the fix on Windows 10 and Ubuntu 20.04 using Nightly 89.0a1 (20210413035647)

Status: RESOLVED → VERIFIED
status-firefox89: fixed → verified
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: