Closed Bug 1703398 Opened 4 years ago Closed 4 years ago

Remove "the" from "Close tabs to the Left" and "Close tabs to the Right" tab strip context menu items

Categories

(Firefox :: Menus, defect, P1)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
89 Branch
Tracking Status
firefox89 --- verified

People

(Reporter: Gijs, Assigned: flod)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-context-menus] [priority:2b])

Attachments

(1 file)

As in summary.

Summary: Remove "the" from "Close tabs to the Left" and "Close tabs to the Right" context menu items → Remove "the" from "Close tabs to the Left" and "Close tabs to the Right" tab strip context menu items
Assignee: nobody → francesco.lodolo
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [proton-context-menus] → [proton-context-menus] [priority:2b]
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/6ad1deea42ff Remove "the" in "Close Tabs to the Left/Right" menus, r=Gijs,fluent-reviewers
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Priority: P2 → P1

Verified that both Close Tabs to the Left/Right are now changed to Close Tabs to Left/Right in latest Nightly 89.0a1 across platforms (Windows 10, macOS 11.3 and Ubuntu 18.04) and the functionality of the labels are not affected.

Status: RESOLVED → VERIFIED

Do we no longer change ids whenever localizable texts are changed?

(In reply to Masatoshi Kimura [:emk] from comment #6)

Do we no longer change ids whenever localizable texts are changed?

We don't change IDs when the change is considered not revant for other locales (capitalization, typos), to avoid losing translations. That has always been the case.

This is an edge case, so it comes down to a personal call. It was still called out in communications to localizers.

Is the new version correct language-wise? "Close Tabs to Left/Right" sounds quite odd (I'm not a native speaker, though).

If shortening is required I would've gone with something like "Close Left/Right tabs".

As the options are in a submenu "Close multiple tabs" these days one could go even shorter with just "Left/Right tabs" and "Other tabs" respectively" as the verb is already included in the top level menu name.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: