1703411 - toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js failing after Find bar styling changes

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[:Gijs (he/him)]

[task 2021-04-06T21:36:04.584Z] 21:36:04     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Element left border color should be set. - "rgb(139, 142, 143)" == "rgb(255, 255, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js :: testBorderColor :: line 83
[task 2021-04-06T21:36:04.585Z] 21:36:04     INFO - Stack trace:
[task 2021-04-06T21:36:04.585Z] 21:36:04     INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js:testBorderColor:83
[task 2021-04-06T21:36:04.586Z] 21:36:04     INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_field_properties_on_findbar:109
[task 2021-04-06T21:36:04.587Z] 21:36:04     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-04-06T21:36:04.588Z] 21:36:04     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Element right border color should be set. - "rgb(139, 142, 143)" == "rgb(255, 255, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js :: testBorderColor :: line 88
[task 2021-04-06T21:36:04.589Z] 21:36:04     INFO - Stack trace:
[task 2021-04-06T21:36:04.589Z] 21:36:04     INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js:testBorderColor:88
[task 2021-04-06T21:36:04.590Z] 21:36:04     INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_field_properties_on_findbar:109
[task 2021-04-06T21:36:04.591Z] 21:36:04     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-04-06T21:36:04.592Z] 21:36:04     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Element top border color should be set. - "rgb(139, 142, 143)" == "rgb(255, 255, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js :: testBorderColor :: line 93
[task 2021-04-06T21:36:04.592Z] 21:36:04     INFO - Stack trace:
[task 2021-04-06T21:36:04.593Z] 21:36:04     INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js:testBorderColor:93
[task 2021-04-06T21:36:04.593Z] 21:36:04     INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_field_properties_on_findbar:109
[task 2021-04-06T21:36:04.594Z] 21:36:04     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-04-06T21:36:04.594Z] 21:36:04     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Element bottom border color should be set. - "rgb(139, 142, 143)" == "rgb(255, 255, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js :: testBorderColor :: line 98
[task 2021-04-06T21:36:04.595Z] 21:36:04     INFO - Stack trace:
[task 2021-04-06T21:36:04.595Z] 21:36:04     INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js:testBorderColor:98
[task 2021-04-06T21:36:04.596Z] 21:36:04     INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_field_properties_on_findbar:109
[task 2021-04-06T21:36:04.600Z] 21:36:04     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-04-06T21:36:04.601Z] 21:36:04     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Element left border color should be set. - "rgb(139, 142, 143)" == "rgb(255, 255, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js :: testBorderColor :: line 83
[task 2021-04-06T21:36:04.602Z] 21:36:04     INFO - Stack trace:
[task 2021-04-06T21:36:04.603Z] 21:36:04     INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js:testBorderColor:83
[task 2021-04-06T21:36:04.603Z] 21:36:04     INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_field_properties_on_findbar:110
[task 2021-04-06T21:36:04.604Z] 21:36:04     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-04-06T21:36:04.605Z] 21:36:04     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Element right border color should be set. - "rgb(139, 142, 143)" == "rgb(255, 255, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js :: testBorderColor :: line 88
[task 2021-04-06T21:36:04.606Z] 21:36:04     INFO - Stack trace:
[task 2021-04-06T21:36:04.606Z] 21:36:04     INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js:testBorderColor:88
[task 2021-04-06T21:36:04.607Z] 21:36:04     INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_field_properties_on_findbar:110
[task 2021-04-06T21:36:04.608Z] 21:36:04     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-04-06T21:36:04.609Z] 21:36:04     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Element top border color should be set. - "rgb(139, 142, 143)" == "rgb(255, 255, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js :: testBorderColor :: line 93
[task 2021-04-06T21:36:04.610Z] 21:36:04     INFO - Stack trace:
[task 2021-04-06T21:36:04.611Z] 21:36:04     INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js:testBorderColor:93
[task 2021-04-06T21:36:04.611Z] 21:36:04     INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_field_properties_on_findbar:110
[task 2021-04-06T21:36:04.612Z] 21:36:04     INFO - Not taking screenshot here: see the one that was previously logged
[task 2021-04-06T21:36:04.613Z] 21:36:04     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js | Element bottom border color should be set. - "rgb(139, 142, 143)" == "rgb(255, 255, 255)" - JS frame :: chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js :: testBorderColor :: line 98
[task 2021-04-06T21:36:04.613Z] 21:36:04     INFO - Stack trace:
[task 2021-04-06T21:36:04.614Z] 21:36:04     INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/head.js:testBorderColor:98
[task 2021-04-06T21:36:04.615Z] 21:36:04     INFO - chrome://mochitests/content/browser/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js:test_support_toolbar_field_properties_on_findbar:110
[task 2021-04-06T21:36:04.615Z] 21:36:04     INFO - Leaving test bound test_support_toolbar_field_properties_on_findbar

Looks like this probably broke with bug 1702350. This is a blocker for turning on the proton pref. :ntim, can you take a look as you wrote and landed the regressing patch?

Comment 2

[Tim Nguyen :ntim]

Haven't checked, but wrapping these:
https://searchfox.org/mozilla-central/rev/be413c29deeb86be6cdac22445e0d0b035cb9e04/toolkit/components/extensions/test/browser/browser_ext_themes_findbar.js#88-91,109-110

in a if (!gProton) { check should be enough, the border-color prop shouldn't be applied with Proton on the prev/next buttons.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1690334

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1703411 - Update browser_ext_themes_findbar.js to check that prev/next border colors are unchanged when a theme is applied if Proton is enabled.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5049f34129e
Update browser_ext_themes_findbar.js to check that prev/next border colors are unchanged when a theme is applied if Proton is enabled. r=Gijs

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a5049f34129e