Closed
Bug 1703419
Opened 3 years ago
Closed 3 years ago
Native menus set checked="false" attributes unnecessarily, causing test failures
Categories
(Core :: Widget: Cocoa, defect, P1)
Tracking
()
RESOLVED
FIXED
89 Branch
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
References
Details
(Whiteboard: [proton-context-menus][mac:mr1])
Attachments
(2 files)
We have some test failures that are due to unnecessary checked="false" attributes set from the native menu code.
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D111023
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/09acdcb865bb Replace IsElement checks with an assert. r=tnikkel https://hg.mozilla.org/integration/autoland/rev/6c261a59cd92 When an item is unchecked, remove the checked attribute rather than setting it to false, and don't touch the checked attribute during initialization. r=tnikkel
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/09acdcb865bb
https://hg.mozilla.org/mozilla-central/rev/6c261a59cd92
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox89:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
|
||
Updated•2 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•