1703419 - Native menus set checked="false" attributes unnecessarily, causing test failures

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P1)

Description

[Markus Stange [:mstange]]

We have some test failures that are due to unnecessary checked="false" attributes set from the native menu code.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1703419 - Replace IsElement checks with an assert. r=harry,tnikkel

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1703419 - When an item is unchecked, remove the checked attribute rather than setting it to false, and don't touch the checked attribute during initialization. r=harry,tnikkel

Depends on D111023

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09acdcb865bb
Replace IsElement checks with an assert. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/6c261a59cd92
When an item is unchecked, remove the checked attribute rather than setting it to false, and don't touch the checked attribute during initialization. r=tnikkel

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/09acdcb865bb
https://hg.mozilla.org/mozilla-central/rev/6c261a59cd92