1703443 - Move MayGCNow to CCGCScheduler

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P3)

Description

[Paul Bone [:pbone]]

After Bug 1629064 lands there's some refactoring we could do.

Comment 1

[Paul Bone [:pbone]]

Generally I want to move more of the scheduling state for GCs that's scattered throughout nsJSEnvironment.cpp into the CCGCScheduler class. This will avoid the kinds of edge cases that sfink found and wishes to fix in Bug 1711128.

Oh, and I may land these seperatly so that some of the weird regressions that are common when tweaking scheduling can be found a bit more easily.

Comment 2

[Paul Bone [:pbone]]

Attachment: Bug 1703443 - pt 1. Tell the CCGCScheduler that we're shutting down r=smaug

Set the shutdown flag in both shutdown cases.

Comment 3

[Paul Bone [:pbone]]

Attachment: Bug 1703443 - pt 2. Remove dead code r=smaug

Depends on D118336

Comment 4

[Paul Bone [:pbone]]

Attachment: Bug 1703443 - pt 3. Move GC scheduling code into CCGCScheduler r=smaug

Depends on D118337

Comment 5

[Paul Bone [:pbone]]

Attachment: Bug 1703443 - pt 4. Move the CC runner into CCGCScheduler r=smaug

Depends on D118338

Comment 6

[Paul Bone [:pbone]]

Attachment: Bug 1703443 - pt 5. Move KillTimers code into CCGCScheduler r=smaug

Depends on D118339

Comment 7

[Paul Bone [:pbone]]

Attachment: Bug 1703443 - pt 6. Move RunNextCollectorTimer() into CCGCScheduler r=smaug

Depends on D118340

Comment 8

[Paul Bone [:pbone]]

Attachment: Bug 1703443 - pt 7. Make GC/CC runners private to CCGCScheduler and move more code r=smaug

Depends on D118341

Comment 9

[Paul Bone [:pbone]]

Attachment: Bug 1703443 - pt 8. Factor out some common code r=smaug

Depends on D118342

Comment 10

[Paul Bone [:pbone]]

Attachment: Bug 1703443 - pt 9. Remove incorrect comment r=smaug

I was not supposed to commit this comment in an earlier change.

Depends on D118343

Comment 11

[Paul Bone [:pbone]]

Attachment: Bug 1703443 - pt 10. Make mMajorGCReason private r=smaug

Depends on D118694

Comment 12

[Paul Bone [:pbone]]

Attachment: Bug 1703443 - pt 11. Move the shrinking GC fields and logic into CCGCScheduler r=smaug

Depends on D118695

Comment 13

[Paul Bone [:pbone]]

Attachment: Bug 1703443 - pt 12. Call KillAllTimersAndRunners from Shutdown() r=smaug

Depends on D118696

Comment 14

[Paul Bone [:pbone]]

Attachment: Bug 1703443 - pt 15. Move more CCGCScheduler implementation into the .cpp file r=smaug

Depends on D118697

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/742f1dc1612f
pt 1. Tell the CCGCScheduler that we're shutting down r=smaug
https://hg.mozilla.org/integration/autoland/rev/7e2c90da4fbb
pt 2. Remove dead code r=smaug
https://hg.mozilla.org/integration/autoland/rev/5a900829cbd1
pt 3. Move GC scheduling code into CCGCScheduler r=smaug
https://hg.mozilla.org/integration/autoland/rev/39bd5b2ec9e0
pt 4. Move the CC runner into CCGCScheduler r=smaug
https://hg.mozilla.org/integration/autoland/rev/11ccf870e643
pt 5. Move KillTimers code into CCGCScheduler r=smaug
https://hg.mozilla.org/integration/autoland/rev/341dd4d5b370
pt 6. Move RunNextCollectorTimer() into CCGCScheduler r=smaug
https://hg.mozilla.org/integration/autoland/rev/251a9a597c91
pt 7. Make GC/CC runners private to CCGCScheduler and move more code r=smaug
https://hg.mozilla.org/integration/autoland/rev/f55e0c5e710f
pt 8. Factor out some common code r=smaug
https://hg.mozilla.org/integration/autoland/rev/8e6c4e4c5429
pt 9. Remove incorrect comment r=smaug
https://hg.mozilla.org/integration/autoland/rev/c602e39f64fd
pt 10. Make mMajorGCReason private r=smaug
https://hg.mozilla.org/integration/autoland/rev/e8c6a26493b4
pt 11. Move the shrinking GC fields and logic into CCGCScheduler r=smaug
https://hg.mozilla.org/integration/autoland/rev/589311f587ce
pt 11. Call KillAllTimersAndRunners from Shutdown() r=smaug
https://hg.mozilla.org/integration/autoland/rev/5b2b19d5a0a2
pt 12. Move more CCGCScheduler implementation into the .cpp file r=smaug

Comment 16

[Cristian Brindusan [:cbrindusan]]

Backed out 13 changesets (bug 1703443) for causing GTest failures.
https://hg.mozilla.org/integration/autoland/rev/531323de1a48ea8a49a329fb22f08373e46df620

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=5b2b19d5a0a20b73e26bd7912a6fe610134095ae&selectedTaskRun=Aeu5V-4CSDS1Iium_IeeHA.0

https://treeherder.mozilla.org/jobs?repo=autoland&revision=5b2b19d5a0a20b73e26bd7912a6fe610134095ae&selectedTaskRun=SEC3aj_NTZ-vyAoOuHreMw.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=343830009&repo=autoland&lineNumber=30355
https://treeherder.mozilla.org/logviewer?job_id=343829965&repo=autoland&lineNumber=6160

Comment 17

[Paul Bone [:pbone]]

Attachment: Bug 1703443 - pt 13. Pass in the now timestamp as a parameter r=smaug

By passing this as a parameter we can remove the duplicated Now() procedure.

Depends on D118697

Comment 18

[Paul Bone [:pbone]]

Attachment: Bug 1703443 - pt 14. Pass aSuspectedCCObjects into CC scheduling code r=smaug

Pass this value in also and remove the need for duplicate inlined
definitions between Firefox and gtest.

Depends on D119362

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71458c1f6a55
pt 1. Tell the CCGCScheduler that we're shutting down r=smaug
https://hg.mozilla.org/integration/autoland/rev/63dcb96c1d77
pt 2. Remove dead code r=smaug
https://hg.mozilla.org/integration/autoland/rev/0321a81ceec2
pt 3. Move GC scheduling code into CCGCScheduler r=smaug
https://hg.mozilla.org/integration/autoland/rev/aa62c19de048
pt 4. Move the CC runner into CCGCScheduler r=smaug
https://hg.mozilla.org/integration/autoland/rev/ca6e154e215b
pt 5. Move KillTimers code into CCGCScheduler r=smaug
https://hg.mozilla.org/integration/autoland/rev/efd4b9f23fde
pt 6. Move RunNextCollectorTimer() into CCGCScheduler r=smaug
https://hg.mozilla.org/integration/autoland/rev/3b70d65372e7
pt 7. Make GC/CC runners private to CCGCScheduler and move more code r=smaug
https://hg.mozilla.org/integration/autoland/rev/02826afb7367
pt 8. Factor out some common code r=smaug
https://hg.mozilla.org/integration/autoland/rev/cd1be6870ff7
pt 9. Remove incorrect comment r=smaug
https://hg.mozilla.org/integration/autoland/rev/0768e9452197
pt 10. Make mMajorGCReason private r=smaug
https://hg.mozilla.org/integration/autoland/rev/a17b19c72ec1
pt 11. Move the shrinking GC fields and logic into CCGCScheduler r=smaug
https://hg.mozilla.org/integration/autoland/rev/6817f0dffd39
pt 12. Call KillAllTimersAndRunners from Shutdown() r=smaug
https://hg.mozilla.org/integration/autoland/rev/657f50acf609
pt 13. Pass in the now timestamp as a parameter r=smaug
https://hg.mozilla.org/integration/autoland/rev/08f3a7a19041
pt 14. Pass aSuspectedCCObjects into CC scheduling code r=smaug
https://hg.mozilla.org/integration/autoland/rev/6536139589b1
pt 15. Move more CCGCScheduler implementation into the .cpp file r=smaug

Comment 20

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/71458c1f6a55
https://hg.mozilla.org/mozilla-central/rev/63dcb96c1d77
https://hg.mozilla.org/mozilla-central/rev/0321a81ceec2
https://hg.mozilla.org/mozilla-central/rev/aa62c19de048
https://hg.mozilla.org/mozilla-central/rev/ca6e154e215b
https://hg.mozilla.org/mozilla-central/rev/efd4b9f23fde
https://hg.mozilla.org/mozilla-central/rev/3b70d65372e7
https://hg.mozilla.org/mozilla-central/rev/02826afb7367
https://hg.mozilla.org/mozilla-central/rev/cd1be6870ff7
https://hg.mozilla.org/mozilla-central/rev/0768e9452197
https://hg.mozilla.org/mozilla-central/rev/a17b19c72ec1
https://hg.mozilla.org/mozilla-central/rev/6817f0dffd39
https://hg.mozilla.org/mozilla-central/rev/657f50acf609
https://hg.mozilla.org/mozilla-central/rev/08f3a7a19041
https://hg.mozilla.org/mozilla-central/rev/6536139589b1