1703464 - CORP check should be bypassed when the LoadingPrincipal is a SystemPrincipal

Status: RESOLVED FIXED

(Core :: DOM: Networking, defect, P3)

Description

[Tom Tung [:tt, :ttung]]

STR:

1. Ensure dom.security.secFetch.enabled is false (Nightly is true by default)
2. Open https://translate.google.com/
3. Click "Add Search Engine" from the page actions menu in the location bar.

Actual Result:

• Download Error and the status code is NS_ERROR_DOM_CORP_FAILED.

Expected Result:

• The search engine is successfully added.

The CORP check is here and it seems that the check assume the loading principal cannot be a system principal.

Comment 1

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1703464 - Bypass the CORP check when the loading principal is a system principal;

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41655bc31215
Bypass the CORP check when the loading principal is a system principal; r=necko-reviewers,dragana

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/41655bc31215

Comment 4

[Wladimir Palant]

For reference: this caused bug 1698755, so maybe this is worth backporting to 78 branch.