1703490 - [Wayland] Remove duplicate D&D handlers

Status: RESOLVED WONTFIX

(Core :: Widget: Gtk, task)

Description

[Martin Stránský [:stransky] (ni? me)]

We use duplicated D&D Wayland handlers, let's use the Gtk ones only.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1703490 [Wayland] Remove duplicate Drag&Drop handlers, r?jhorak

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/003fab04d7cc
[Wayland] Remove duplicate Drag&Drop handlers, r=rmader

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/003fab04d7cc

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Can you please revert this bug to fix caused regression? (Bug 1704287).
Thanks.

Comment 5

[Iulian Moraru]

Backed out changeset 003fab04d7cc (bug 1703490) for causing Bug 1704287

Backout link

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Martin: Please request a backout (similar to approval-mozilla-beta? request, copy the template from a different bug if needed) and needinfo :pascalc to get it reverted on beta.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Beta backout Approval Request

User impact if declined: Broken Drag and Drop operations on Wayland (due to Mutter compositor bugs).
Is this code covered by automated tests?: No
Has the fix been verified in Nightly?: Yes
Needs manual test from QE?: No
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): We're reverting to know working state at Firefox 88.

Comment 8

[Pascal Chevrel:pascalc]

Backed out in beta https://hg.mozilla.org/releases/mozilla-beta/rev/c5a7890deee1

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Thanks, let's close it.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

AFAICT this was never backed out from m-c. Given comment 9, it sounds like we should?

Comment 11

[Robert Mader [:rmader]]

It was in comment 5 and is on m-c , see https://searchfox.org/mozilla-central/source/widget/gtk/nsClipboardWayland.cpp#38-47

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Ah yeah, missed that. Thanks.