1703502 - Perma Android bustage widget/android/GfxInfo.cpp:678:62: error: function definition is not allowed here when Gecko 89 merges to Beta on 2021-04-19

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

• central-as-beta simulation
• How to run these simulations
• Failure log

[task 2021-04-07T10:32:58.648Z] 10:32:58     INFO -  In file included from Unified_cpp_widget_android0.cpp:83:
[task 2021-04-07T10:32:58.648Z] 10:32:58    ERROR -  /builds/worker/checkouts/gecko/widget/android/GfxInfo.cpp:678:62: error: function definition is not allowed here
[task 2021-04-07T10:32:58.648Z] 10:32:58     INFO -  static nsCString FeatureCacheOsVerPrefName(int32_t aFeature) {
[task 2021-04-07T10:32:58.648Z] 10:32:58     INFO -                                                               ^

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1703502 - move closing curly brace out of ifdef block to fix non-Nightly Android builds. r=sotaro

Curly brace got moved into ifdef block in bug 1803140

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74f2d9673c2d
move closing curly brace out of ifdef block to fix non-Nightly Android builds. r=emilio

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/74f2d9673c2d

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed in today's central-as-beta simulation.