Closed Bug 1703596 Opened 1 month ago Closed 1 month ago

Remove JSID_IS_ATOM from js/src/jit/VMFunctions.cpp

Categories

(Core :: JavaScript Engine, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: mgaudet, Assigned: bukky.akinnadeju17, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Note: this bug is currently reserved for Outreachy applicants for the Spring/Summer 2021 cycle. If it has not been completed by the end of the application cycle, we will open it up.

Background

The JSID_IS_ATOM calls reflect an old style of SpiderMonkey programming that we think we can start to get away from, internally to the engine.

This Bug

This bug is about removing uses of JSID_IS_ATOM within the js/src/jit/VMFunctions.cpp file. Instead of using JSID_IS_ATOM we should be using JS::PropertyKey::isAtom, which is actually how JSID_IS_ATOM is implemented.

Prerequisites

Before getting started, you'll want to

How you’ll know you’re done

  • The use of JSID_IS_ATOM is removed
  • SpiderMonkey builds
  • The tests run successfully.

Bonus:

  • If you happen to see nearby uses of JSID_TO_ATOM, we should also remove those.

Getting Help

Feel free to leave comments on this bug for questions, or, if you have more synchronous questions about this bug, feel free to drop into the #spidermonkey channel on chat.mozilla.org.

Tips:

  • Not sure if the code you've been editing is getting run? Insert a call to MOZ_CRASH, a macro which will crash when executed, and run the entire test suite with an optimized build (for speed). If you see crashes, you can then use a debug build to make sure it's crashing in your code!

I am interested in this bug, can i get on with it?

Absolutely!

Assignee: nobody → bukky.akinnadeju17
Status: NEW → ASSIGNED
Pushed by mgaudet@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0fc141f13f6f
Remove JSID_IS_ATOM from js/src/jit/VMFunctions.cpp. r=mgaudet
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.