Note: this bug is currently reserved for Outreachy applicants for the Spring/Summer 2021 cycle. If it has not been completed by the end of the application cycle, we will open it up.
JSID_IS_ATOM calls reflect an old style of SpiderMonkey programming that we think we can start to get away from, internally to the engine.
This bug is about removing uses of
JSID_IS_ATOM within the
js/src/jsapi.cpp file. Instead of using
JSID_IS_ATOM we should be using
JS::PropertyKey::isAtom, which is actually how
JSID_IS_ATOM is implemented.
Before getting started, you'll want to
How you’ll know you’re done
- The use of
JSID_IS_ATOM is removed
- SpiderMonkey builds
- The tests run successfully.
- If you happen to see nearby uses of
JSID_TO_ATOM, we should also remove those.
Feel free to leave comments on this bug for questions, or, if you have more synchronous questions about this bug, feel free to drop into the #spidermonkey channel on chat.mozilla.org.
- Not sure if the code you've been editing is getting run? Insert a call to
MOZ_CRASH, a macro which will crash when executed, and run the entire test suite with an optimized build (for speed). If you see crashes, you can then use a debug build to make sure it's crashing in your code!