1703629 - Prompts should be automatically dismissed on page navigation

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[[ex-Mozilla] Agi Sferro | :agi]

Right now GV prompts are alive even when the page that originates it navigates away, this is a problem as it can cause an XSS (see Bug 1701684)

Comment 1

[Daniel Veditz [:dveditz]]

]"sec-other" because this is a task to fix another issue so we're not double-counting. I guess there could be other exploits that abuse this behavior though.

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Will post a patch soon (hopefully tomorrow)

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1703629 - Discard useless prompts.

Comment 4

[[ex-Mozilla] Agi Sferro | :agi]

Comment on attachment 9214765 [details]
Bug 1703629 - Discard useless prompts.

Security Approval Request

• How easily could an exploit be constructed based on the patch?: The patch is vague/generic enough that it shouldn't be too obvious what the problem is. It does point at prompt acting on the wrong window which is a good hint though, only if you read the code, the commit message is vague on purpose.
• Do comments in the patch, the check-in comment, or tests included in the patch paint a bulls-eye on the security problem?: No
• Which older supported branches are affected by this flaw?: all
• If not all supported branches, which bug introduced the flaw?: None
• Do you have backports for the affected branches?: Yes
• If not, how different, hard to create, and risky will they be?:
• How likely is this patch to cause regressions; how much testing does it need?: It might cause some regressions in prompts being discarded too eagerly, there might be cases not covered by automation where we do want to keep a prompt around when the page navigates that I didn't think of.

Comment 5

[Tom Ritter [:tjr]]

Comment on attachment 9214765 [details]
Bug 1703629 - Discard useless prompts.

Approved to request uplift; if granted we can land it.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9214765 [details]
Bug 1703629 - Discard useless prompts.

This missed 88.0-rc1 already. I'll leave it on the radar in case of a respin, however.

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Discard useless prompts. r=aklotz
https://hg.mozilla.org/integration/autoland/rev/bd9e313301d575aef46dddfd51a0736e308ff5f1
https://hg.mozilla.org/mozilla-central/rev/bd9e313301d5

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9214765 [details]
Bug 1703629 - Discard useless prompts.

Approved for Fenix 88.1.3 & Focus 8.15.3

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/3e1b37cc64e5