1703644 - Intermittent toolkit/mozapps/extensions/test/browser/browser_panel_item_accesskey.js | application crashed [@ MergeState::AddNewNode ...]

Status: RESOLVED FIXED

(Core :: Web Painting, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: jwein [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=335733291&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/eb3Ip8FoQ1qzDJLtoNl0dQ/runs/0/artifacts/public/logs/live_backing.log

---

This is crashing when we set browser.proton.enabled=true on autoland```

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1703644 - Disable Proton when running browser_panel_item_accesskey.js due to crashing in MergeState::AddNewNode.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/582926857753
Disable Proton when running browser_panel_item_accesskey.js due to crashing in MergeState::AddNewNode. r=mstriemer

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/582926857753

Comment 4

[Intermittent Failures Robot]

1 failures in 3854 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• windows10-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1703644&startday=2021-04-05&endday=2021-04-11&tree=all

Comment 5

[:Gijs (out for now; he/him)]

We can't remove this pref flip (and thus can't remove the code that is preffed off by default everywhere else) right now because the crashes recur on try, see e.g. https://treeherder.mozilla.org/jobs?repo=try&revision=e42cbebf6f895a9ca70f722d41214514768bb0ad&selectedTaskRun=YmVpO-HiQ3eFLD0qEtXqRw.0 .

Miko or Sotaro, could you help us figure out what is going on here?

Comment 6

[Timothy Nikkel (:tnikkel)]

Try on a new base revision that has bug 1693496, which fixes a similar crash in this same test in tsan builds.

Comment 7

[:Gijs (out for now; he/him)]

(In reply to Timothy Nikkel (:tnikkel) from comment #6)

Try on a new base revision that has bug 1693496, which fixes a similar crash in this same test in tsan builds.

Oh, cool! I pushed:

https://treeherder.mozilla.org/jobs?repo=try&revision=5d3af677bcde5823809e80a8423cc589cae9b3eb

Looks promising.

Comment 8

[:Gijs (out for now; he/him)]

Attachment: Bug 1703644 - stop disabling proton in browser_panel_item_accesskey.js, r?Masterwayz

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61a1532b4be2
stop disabling proton in browser_panel_item_accesskey.js, r=MasterWayZ

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/61a1532b4be2