1703665 - Remove usage of --android-storage in Raptor / Browsertime

Status: RESOLVED FIXED

(Testing :: Raptor, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Currently Raptor / Browsertime uses the --android-storage option from geckodriver to store all test related files on the internal location. This seems to have been done to get minidumps from the device.

https://searchfox.org/mozilla-central/rev/62135a96327f42fd1ccf8a04feb62be04b102195/testing/raptor/raptor/browsertime/android.py#96-98

With the upcoming geckodriver 0.29.1 release the default of this argument will be sdcard and all files are put under $EXTERNAL_STORAGE (see bug 1680407). That means this folder is accessible for all devices including unrooted ones.

As such we would like to remove this deprecated argument with the next geckodriver 0.30.0 release (bug 1700559).

Greg, could someone please have a look so that its usage can be removed from Raptor / Browsertime? It's the only consumer of geckodriver that is using it, and blocking us from removing the argument.

Thanks!

Comment 1

[Greg Mierzwinski [:sparky]]

Yup, I've filed a JIRA ticket for this.

Comment 2

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Attachment: Bug 1703665 Remove usage of --android-storage in Raptor / Browsertime r=#perftest,whimboo

Comment 3

[Alexandru Ionescu (needinfo me) [:alexandrui]]

The patch works fine locally but on try fails. Talked to sparky and he said that it might interfere with mozharness. I am currently debugging it on try, but it works very slow. Don't think anybody can help me, but just time to debug and find the issue.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c631df1e37c5
Remove usage of --android-storage in Raptor / Browsertime r=perftest-reviewers,sparky

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Greg, do you think that uplifting to late beta would be doable if that sticks? Would be great to see that with the next release of Firefox the --android-storage argument is no longer used in our CI.

Comment 6

[Greg Mierzwinski [:sparky]]

Yup, that should be fine. I don't think there's any other patches we'll need to uplift for this either.

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/c631df1e37c5

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Greg Mierzwinski [:sparky] from comment #6)

Yup, that should be fine. I don't think there's any other patches we'll need to uplift for this either.

Great. Can you please schedule the uplift? Given that this patch is related to testing only we won't have to request approval.

Comment 9

[Greg Mierzwinski [:sparky]]

Comment on attachment 9217693 [details]
Bug 1703665 Remove usage of --android-storage in Raptor / Browsertime r=#perftest,whimboo

Beta/Release Uplift Approval Request

• User impact if declined: No user impact.
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch only changes how crash reports are gathered. They remove some code from Raptor which is being deprecated in Marionette.
• String changes made/needed:

Comment 10

[Greg Mierzwinski [:sparky]]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #8)

(In reply to Greg Mierzwinski [:sparky] from comment #6)

Yup, that should be fine. I don't think there's any other patches we'll need to uplift for this either.

Great. Can you please schedule the uplift? Given that this patch is related to testing only we won't have to request approval.

I'm not sure how to schedule an uplift but I've requested approval for it.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

An approval is only needed for code that is outside of testing. So in this case it would be possible to directly land on beta in case nothing has been changed. CC'ing Ryan who can help.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

We're in RC week, so Beta's already frozen until Monday's merge. Is there a particularly urgent need to get this on 89 at this point?

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Not really. It would also be fine to get it uplifted to release when that code is on 90 beta. Would that be possible? Otherwise we would have to wait for the next full release cycle before we can get started on bug 1700559.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9217693 [details]
Bug 1703665 Remove usage of --android-storage in Raptor / Browsertime r=#perftest,whimboo

test-only changes don't need to go through approval

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/7ad8c8036c67