1703670 - Remove expired Telemetry probe networking.ftp_opened_channels_files

Status: RESOLVED FIXED

(Core :: Networking, task, P5)

Description

[Jenny Zhang]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.114 Safari/537.36

Comment 1

[Jenny Zhang]

The following files contain references to the networking.ftp_opened_channels_files Telemetry probe.

This line and this line in netwerk/protocol/ftp/nsFtpConnectionThread.cpp and these lines in toolkit/components/telemetry/Scalars.yaml may be removed.

I would like to work on removing this probe.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Networking' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 3

[Dragana Damjanovic [:dragana]]

Valentin, can you take a look if we have more telemetry probes related to ftp that we can remove?

Comment 4

[Valentin Gosu [:valentin] (he/him)]

These are the only FTP telemetry probes we have as far as I can tell.
Feel free to submit a patch.

Comment 5

[Jenny Zhang]

Attachment: Patch removing the relevant telemetry probe.

Comment 6

[Valentin Gosu [:valentin] (he/him)]

Please submit the patch using phabricator. Thanks!
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#to-submit-a-patch

Comment 7

[Jenny Zhang]

Attachment: Bug 1703670: Removed expired telemetry probe networking.ftp_opened_channels_files and networking.ftp_opened_channels_listings

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e58a73e278b
Removed expired telemetry probe networking.ftp_opened_channels_files and networking.ftp_opened_channels_listings r=chutten,necko-reviewers,valentin

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5e58a73e278b