1703807 - Customize toolbar page - update checkboxes focus rings to respect Proton format

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, enhancement, P3)

Description

[Cristian Fogel [:cfogel]]

Attachment: checkstomize.png

Affected versions

• 89.0a1(2021-04-07)

Affected platforms

• Win10;

Steps to reproduce

• pref set to true: browser.proton.enabled

1. Launch Firefox, right click on the toolbar click on Customize toolbar option;
2. Click on Drag Space checkbox;
3. Shift+TAB to reach Title Bar checkbox;

Expected result

• checkboxes have the Proton styling applied;

Actual result

• only colors updated to Proton styling;

Regression range

• visible with proton changes;

Additional notes

• remains to be confirmed on Ubuntu;
• set as S4, as this might not be worked upon yet;
• same for Checkbox for Density and Dragspage;
• attached screenshot to illustrate the issue.

Comment 1

[Itiel]

Attachment: Bug 1703807 - Adjust non-native checkboxes and menulists focus ring for Proton r?mconley

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1695cda8cf9
Adjust non-native checkboxes and menulists focus ring for Proton r=mconley

Comment 3

[Cristian Brindusan [:cbrindusan]]

Backed out changeset b1695cda8cf9 (Bug 1703807) for causing bc failures in browser_parsable_css.js.
https://hg.mozilla.org/integration/autoland/rev/8dfe8c91f1d7fb7d7757811c08f43513a7aeae67

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=b1695cda8cf952331addc65abafaae9997fedfce&selectedTaskRun=ATCpUprYSHWznFHZCf0RWw.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=336406685&repo=autoland&lineNumber=2643

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0aac8041b5fd
Adjust non-native checkboxes and menulists focus ring for Proton r=mconley

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0aac8041b5fd

Comment 6

[Alexandru Trif, Desktop QA [:atrif]]

Verified fixed with 89.0a1 (20210414093129) on Windows 10x64. The checkboxes have proton styling.