1703967 - Add test case for getFontPreviewData()

Status: RESOLVED FIXED

(DevTools :: Shared Components, enhancement)

Description

[Sebastian Zartner [:sebo]]

In bug 872078 support for multi-line font previews got added, though at the moment there is no test case checking the functionality of the underlying getFontPreviewData() method.

This bug is meant to create an automated test case for it next to https://searchfox.org/mozilla-central/source/devtools/server/tests/xpcshell/test_getRuleText.js.

The test case requires some system and web fonts to be loaded to generate a preview for them.

See also Julien's note in Phabricator.

Sebastian

Comment 1

[Julian Descottes [:jdescottes]]

I think it's going to be difficult to use xpcshell tests here, since the helper relies on document APIs.
Instead, let's add a browser mochitest. I will share a test skeleton.

Comment 2

[Julian Descottes [:jdescottes]]

See basic test at https://hg.mozilla.org/try/rev/19ddb21d62b48da5a281292c54c28f7c975b980d
Needs more asserts but should be enough to get started.

:sebo, are you interested in picking this up?

Comment 3

[Sebastian Zartner [:sebo]]

Sure, I'll have a look at it. Thank you for providing the info and the basic test!

Sebastian

Comment 4

[Sebastian Zartner [:sebo]]

Attachment: Bug 1703967 - Added test case for getFontPreviewData(). r=jdescottes

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46f85b2a6a5f
Added test case for getFontPreviewData(). r=jdescottes

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/46f85b2a6a5f