1703974 - Lazily create tab-notification-deck

Status: RESOLVED DUPLICATE of bug 1704868

(Firefox :: Messaging System, enhancement, P3)

Description

[Mark Striemer [:mstriemer]]

The tab notification deck isn't needed until we show a notification. However it is created when browser.getNotificationBox() is called which happens in onLocationChange in browser.js [1]. This means that we create the deck quite early even though we don't need it.

This code could instead use browser.readNotificationBox() [2] and only remove transient notifications is the notification box already exists.

A test was removed [3] to allow proton infobars to graduate, something similar should be added back and it should also check that we don't create the deck when navigating.

This is a low-severity performance change that I don't think should not block shipping proton.

[1] https://searchfox.org/mozilla-central/rev/3a798ef9252896fb389679f06dd3203169565af0/browser/base/content/browser.js#5900
[2] https://searchfox.org/mozilla-central/rev/3a798ef9252896fb389679f06dd3203169565af0/browser/base/content/tabbrowser.js#847
[3] https://phabricator.services.mozilla.com/D111310

Comment 1

[Mark Striemer [:mstriemer]]

This was fixed by bug 1704868