1704026 - Adjust 'Edit bookmarks folder' modal title to 'Edit "bookmarks folder"'

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, enhancement, P2)

Description

[Romain Testard [:RT]]

Requested Title: Edit "bookmarks folder"
This is a change from original spec, marking as P2c

Comment 1

[Francesco Lodolo [:flod]]

I don't understand: you mean literally double quotes, or that represents the name of the folder?

Comment 2

[Romain Testard [:RT]]

Attachment: modal.png

Yes, double quotes would be displayed in the title as in this example.

Comment 3

[Francesco Lodolo [:flod]]

Sorry, it's still unclear to me: right now the title says Edit bookmarks folder.

If you're editing a folder called "examples", would it say Edit “bookmarks folder” or Edit “examples"?

Comment 4

[Romain Testard [:RT]]

It would be Edit “examples"
NIing Meridel here to validate my understanding is correct

Comment 5

[Meridel [:meridel]]

Attachment: Edit bookmark folder.png

Apologies, but in thinking this through some more, I don't think we should input the custom name of the bookmark or the bookmark folder in either case. It will be cleaner and clearer to use a standard, generic title. Note, "bookmark" is singular in "Edit bookmark folder"

Romain, do two separate bugs need to be filed?

Comment 6

[Micah [:mtigley] (she/her)]

(In reply to Meridel [:meridel] from comment #5)

Apologies, but in thinking this through some more, I don't think we should input the custom name of the bookmark or the bookmark folder in either case. It will be cleaner and clearer to use a standard, generic title. Note, "bookmark" is singular in "Edit bookmark folder"

Just to clarify, we want to make the following string changes(?):

• Edit "custom bookmark name" → Edit bookmark
• Edit bookmarks folder → Edit bookmark folder
• Add bookmarks folder → Add bookmark folder

Comment 7

[Meridel [:meridel]]

That's right, thank you. The final labels are:

Add bookmark
Edit bookmark

Add bookmark folder
Edit bookmark folder

Comment 8

[Micah [:mtigley] (she/her)]

Attachment: Bug 1704026 - Adjust Add/Edit bookmark strings. r?gijs

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/790983d9455c
Adjust Add/Edit bookmark strings. r=Gijs

Comment 10

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failures on browser_bookmarks_change_title.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/84e12950c61e37d03a7bc451b61097061fef1b1b
Log link: https://treeherder.mozilla.org/logviewer?job_id=336570734&repo=autoland&lineNumber=2522

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38c66b4dbb06
Adjust Add/Edit bookmark strings. r=Gijs

Comment 12

[Atila Butkovits]

Backed out for failures at browser_bookmarks_change_title.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/7e95f3a4d6f55aad0889920949894cef40e90e1e

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=linux%2C18.04%2Cx64%2Ctsan%2Copt%2Cmochitests%2Ctest-linux1804-64-tsan%2Fopt-mochitest-browser-chrome-e10s%2Cbc25&revision=38c66b4dbb0670f519d00edd7ded39a86341ac04

Failure log: https://treeherder.mozilla.org/logviewer?job_id=336658826&repo=autoland&lineNumber=2511
https://treeherder.mozilla.org/logviewer?job_id=336658343&repo=autoland&lineNumber=115

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19bd26fe437b
Adjust Add/Edit bookmark strings. r=Gijs

Comment 14

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/19bd26fe437b

Comment 15

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Verified in latest nightly build 90.0a1 (2021-05-13) (64-bit) and beta build 89.0b11 (64-bit)
Labels read:
-Add bookmark
-Edit bookmark

-Add bookmark folder
-Edit bookmark folder
Updating status accordingly.
Best regards,
Clara