1704071 - Improve the address bar /search bar elements contrast during toolbar customization

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, enhancement, P2)

Description

[Adrian Florinescu [:aflorinescu]]

Attachment: customize-addressbar.jpg

[Description:]

This is especially an issue on Windows and dark theme(mac looks better). The contrast, border and shading makes the address bar / search bar customization not a great experience. I'd argue that for the purpose of customization, we'd prefer an element that focuses more on the visibility rathher than 1 to 1 match to the actual element.

[Note:]

1. This is not really a regression, non-proton 87 version has similar address bar element. However, 87 version has the search bar much better contrasted - maybe border/shading?

[Steps:]

1. Open Firefox
2. Open Customize Toolbar.
3. Drag and drop addressbar/searchbar element

Comment 1

[Romain Testard [:RT]]

Attachment: search.png

This is on, on Win10 I get the exact same colors on both.

Comment 2

[Itiel]

(In reply to Romain Testard [:RT] from comment #1)

Created attachment 9215135 [details]
search.png

This is on, on Win10 I get the exact same colors on both.

That screenshot is from normal use; this bug is about how the search bar and url bar look in customize mode, when dragging them.

Comment 3

[Marco Bonardo [:mak]]

we could probably add some borders here

Comment 4

[Marco Bonardo [:mak]]

Attachment: Bug 1704071 - Increase address bar and search bar contrast during toolbar customization. r=adw

To improve the visibility of these input fields this pathc adds a border based
on currentColor and reuse the urlbar shadow. This is a small improvement over the
status-quo, the applied transparencies are controlled by the drag'n'drop code.
This issue exists also in pre-proton, so the styles apply regardless.

Comment 5

[Marco Bonardo [:mak]]

The landing patch should improve the situation but it won't completely solve it, because we have no control over the translucency drawn by the OS. We can re-evaluate once platform adds support for controlling the image.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e76fec22745d
Increase address bar and search bar contrast during toolbar customization. r=harry

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e76fec22745d

Comment 8

[Petruta Horea [:phorea], Desktop QA]

(In reply to Marco Bonardo [:mak] from comment #5)

The landing patch should improve the situation but it won't completely solve it, because we have no control over the translucency drawn by the OS. We can re-evaluate once platform adds support for controlling the image.

It looks indeed better on latest Firefox 89 beta 4. Should we file a follow-up for the remaining work? Thank you!

Comment 9

[Marco Bonardo [:mak]]

(In reply to Petruta Horea [:phorea] from comment #8)

It looks indeed better on latest Firefox 89 beta 4. Should we file a follow-up for the remaining work? Thank you!

There is already some work tracked in bug 1683376 to be able to control the traslucency, and until that is done we can't really do anything.