1704079 - Http3Session::SetSecInfo does not set negotiated NPN

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P3)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

Need to add mSocketControl->SetNegotiatedNPN(secInfo.alpn);

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1704079 - Set negotiated NPN in Http3Session::SetSecInfo. r=#necko!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac4b107bf8bb
Set negotiated NPN in Http3Session::SetSecInfo. r=necko-reviewers,dragana

Comment 3

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/696e947debe8
Backed out changeset ac4b107bf8bb for XPCshell failures in netwerk/test/unit/test_trr_https_fallback.js. CLOSED TREE

Comment 4

[Dorel Luca [:dluca]]

Backed out changeset ac4b107bf8bb (bug 1704079) for XPCshell failures in netwerk/test/unit/test_trr_https_fallback.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=336006573&repo=autoland&lineNumber=3167

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=ac4b107bf8bb337dae1633f128a88958954f84d3

Comment 5

[Dragana Damjanovic [:dragana]]

Nihanth, with your fix property proocolVersion returns proper alpn ("h3-27") no "h3" as it use to return before.
You will need o update tests.

Comment 6

[(inactive) Nihanth Subramanya [:nhnt11]]

(In reply to Dragana Damjanovic [:dragana] from comment #5)

Nihanth, with your fix property proocolVersion returns proper alpn ("h3-27") no "h3" as it use to return before.
You will need o update tests.

I already updated the patch, there's a question for you as well :)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4471f33a2c5
Set negotiated NPN in Http3Session::SetSecInfo. r=necko-reviewers,dragana

Comment 8

[Cristian Brindusan [:cbrindusan]]

Backed out changeset f4471f33a2c5 (Bug 1704079) for xpcshell failures in test_http3_trans_close.js.
https://hg.mozilla.org/integration/autoland/rev/bff4ccb68df8c04bb1e7857bff9f27a415c298fb

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=a1f789984722ce09b644bd9e749ab6697e7fe409&selectedTaskRun=K8d3mLBQQOKr9zd3jLKPOQ.0
https://treeherder.mozilla.org/jobs?repo=autoland&revision=f4471f33a2c58b573f9869fa8a485192cd508317&selectedTaskRun=dNb2YJ7zRM-NC63Wy0hnRw.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=336432580&repo=autoland&lineNumber=2988

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/761184941f0e
Set negotiated NPN in Http3Session::SetSecInfo. r=necko-reviewers,dragana

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/761184941f0e