1704126 - mach bootstrap on M1 fails with "killed: 9"

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[Lars T Hansen [:lth]]

I followed these instructions: https://docs.google.com/document/d/1N5yfEVEISofMmjAxfj3xXONGwyQYBSilsfXqux_M6TM/edit?usp=sharing. Since I had followed older instructions, I uninstalled rust as explained. I then tried to bootstrap in my (updated, but not clean) tree. Mach quits with "Killed: 9".

Comment 1

[Lars T Hansen [:lth]]

Reinstalling rust does not fix the problem, FWIW.

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

A few questions for you:

• Can you post the log? Perhaps there's information that will help determine the failure cause in the log.
• Can you reproduce the failure on a clean central?
• What's in your mozconfig?

Comment 3

[ldhacker]

Attachment: log

Comment 4

[ldhacker]

I am having the same issue.

Comment 5

[ldhacker]

Seems that there needs to be a os check for M1 Macs built into one of the scripts that mach bootstrap calls.

I am continuing to search for it, but have yet to find it.

Comment 6

[ldhacker]

I fixed this issue by individually running the following commands:

'brew install terminal-notifier'
'brew install watchman'
'brew install gnu-tar'

After that, './mach bootstrap' works perfectly.

Comment 7

[Lars T Hansen [:lth]]

Thanks! I did the same, but with an interesting wrinkle: I already had watchman installed, and in order to get bootstrap to work I had to 'brew reinstall watchman', ie, something was not right about that package.

Comment 8

[Mitchell Hentges [:mhentges] 🦀]

Glandium, you're more familiar with M1 Macs than me - do you have a better idea of what's going on here?

Comment 9

[Mike Hommey [:glandium]]

Your python is x86-64, not arm64. If it were arm64, it wouldn't try to install stuff from homebrew at all. We should detect this situation, since, other than causing these sorts of problems, it has a huge impact on build times.

Comment 10

[Lars T Hansen [:lth]]

Weird, since all the pythons seem to have an arm64 personality:

$ file /usr/bin/python
/usr/bin/python: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64e:Mach-O 64-bit executable arm64e]
/usr/bin/python (for architecture x86_64):	Mach-O 64-bit executable x86_64
/usr/bin/python (for architecture arm64e):	Mach-O 64-bit executable arm64e

$ file /usr/bin/python2
/usr/bin/python2: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit executable x86_64] [arm64e:Mach-O 64-bit executable arm64e]
/usr/bin/python2 (for architecture x86_64):	Mach-O 64-bit executable x86_64
/usr/bin/python2 (for architecture arm64e):	Mach-O 64-bit executable arm64e

$ file /opt/homebrew/bin/python3
/opt/homebrew/bin/python3: Mach-O 64-bit executable arm64

Comment 11

[Mike Hommey [:glandium]]

Does which python3 point to one of those?

Comment 12

[Lars T Hansen [:lth]]

(In reply to Mike Hommey [:glandium] from comment #11)

Does which python3 point to one of those?

Yes, it does:

$ which python3
/opt/homebrew/bin/python3
$ ls -l /opt/homebrew/bin/python3
lrwxr-xr-x  1 lhansen  admin  38 Apr 12 08:54 /opt/homebrew/bin/python3 -> ../Cellar/python@3.9/3.9.4/bin/python3
$ file /opt/homebrew/bin/python3
/opt/homebrew/bin/python3: Mach-O 64-bit executable arm64

Comment 13

[Mike Hommey [:glandium]]

Then I guess your tree is old?

Comment 14

[Lars T Hansen [:lth]]

(In reply to Mike Hommey [:glandium] from comment #13)

Then I guess your tree is old?

It shouldn't be, because I updated on Friday last week in order to do some testing. It was old before that, I had probably not updated in several weeks (not primary dev system). I noticed the build instructions had changed, so ...

Comment 15

[Mike Hommey [:glandium]]

What does python3 -c "import platform; print(platform.machine())" say?

Comment 16

[Lars T Hansen [:lth]]

(In reply to Mike Hommey [:glandium] from comment #15)

What does python3 -c "import platform; print(platform.machine())" say?

$ python3 -c "import platform; print(platform.machine())"
arm64

Comment 17

[Mike Hommey [:glandium]]

As per discussion on Matrix yesterday, it's not clear what was wrong but it works now, and it must have been a stale x86-64 python. I'll make bootstrap fail if it's run with an emulated python.

Comment 18

[Mike Hommey [:glandium]]

Attachment: Bug 1704126 - Make mach create-mach-environment fail when running under Rosetta.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb11e35d4f73
Make mach create-mach-environment fail when running under Rosetta. r=firefox-build-system-reviewers,mhentges

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffc825cc89d2
Fix lint failure r=fix CLOSED TREE

Comment 21

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fb11e35d4f73
https://hg.mozilla.org/mozilla-central/rev/ffc825cc89d2