1704133 - Removing stale probe sw.synthesized_res_count

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, task)

Description

[Jin Chun]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.114 Safari/537.36

Comment 1

[Jin Chun]

I'd like to work on this bug. If somebody can officially assign it to me, I'd much appreciate it.

Comment 2

[Jin Chun]

Will be removing these lines in Scalars.yaml and one lines each in the files ServiceWorkerOp.cpp and ServiceWorkerEvents.cpp.

Comment 3

[Jin Chun]

Attachment: patch to remove stale probe synthesized_res_count

Comment 4

[Jin Chun]

It seems the test suite mach test toolkit/components/telemetry/tests/ errors because it cannot locate the test files. I've confirmed they exist, however.

Seems the error is related to testing configurations, not the patch.

Possible relevance to this too?

 1:35.97 SUITE_END
 1:39.00 TEST-UNEXPECTED-FAIL | No tests collected (Not in PYTHON_UNITTEST_MANIFESTS?)
 1:39.13 TEST-UNEXPECTED-FAIL | No tests collected (Not in PYTHON_UNITTEST_MANIFESTS?)
usage: mach [-h] [--binary BINARY] [--address ADDRESS] [--emulator] [--app APP] [--app-arg APP_ARGS] [--profile PROFILE]
            [--setpref PREF=VALUE] [--preferences PREFS_FILES] [--addon ADDONS] [--repeat REPEAT] [--run-until-failure] [--testvars TESTVARS]
            [--symbols-path SYMBOLS_PATH] [--socket-timeout SOCKET_TIMEOUT] [--startup-timeout STARTUP_TIMEOUT] [--shuffle]
            [--shuffle-seed SHUFFLE_SEED] [--total-chunks TOTAL_CHUNKS] [--this-chunk THIS_CHUNK] [--server-root SERVER_ROOT]
            [--gecko-log GECKO_LOG] [--logger-name LOGGER_NAME] [--jsdebugger] [--pydebugger PYDEBUGGER] [--enable-fission]
            [--enable-webrender] [-z] [--tag TEST_TAGS] [--workspace WORKSPACE] [-v] [--emulator-binary EMULATOR_BIN] [--adb ADB_PATH]
            [--avd AVD] [--avd-home AVD_HOME] [--device DEVICE_SERIAL] [--package PACKAGE_NAME] [--log-raw LOG_RAW]
            [--log-unittest LOG_UNITTEST] [--log-xunit LOG_XUNIT] [--log-html LOG_HTML] [--log-mach LOG_MACH] [--log-tbpl LOG_TBPL]
            [--log-grouped LOG_GROUPED] [--log-raw-level LOG_RAW_LEVEL] [--log-mach-verbose] [--log-mach-level LOG_MACH_LEVEL]
            [--log-mach-buffer LOG_MACH_BUFFER] [--log-mach-screenshot] [--log-mach-no-screenshot] [--log-tbpl-compact]
            [--log-tbpl-level LOG_TBPL_LEVEL] [--log-tbpl-buffer LOG_TBPL_BUFFER]
            [tests [tests ...]]
mach: error: Test file(s) not found: toolkit/components/telemetry/tests/marionette/tests/client/test_deletion_request_ping.py toolkit/components/telemetry/tests/marionette/tests/client/test_event_ping.py toolkit/components/telemetry/tests/marionette/tests/client/test_fog_custom_ping.py toolkit/components/telemetry/tests/marionette/tests/client/test_fog_deletion_request_ping.py toolkit/components/telemetry/tests/marionette/tests/client/test_fog_user_activity.py toolkit/components/telemetry/tests/marionette/tests/client/test_main_tab_scalars.py toolkit/components/telemetry/tests/marionette/tests/client/test_search_counts_across_sessions.py toolkit/components/telemetry/tests/marionette/tests/client/test_subsession_management.py toolkit/components/telemetry/tests/marionette/tests/unit/test_ping_server_received_ping.py

Comment 5

[Jin Chun]

Comment on attachment 9214756 [details] [diff] [review]
patch to remove stale probe synthesized_res_count

Attaching patch containing completed removal of stale probe synthesized_res_count.

As per instructions, I've used git to create the patch.

Comment 6

[Jin Chun]

Attachment: Bug 1704133 - Removing stale probe sw.synthesized_res_count

Comment 7

[Chris H-C :chutten]

Recomponenting to the component from the most recent bug in the probe's bug_numbers list, bug 1433916.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The product::component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 9

[Chris H-C :chutten]

(In reply to Jin Chun from comment #4)

It seems the test suite mach test toolkit/components/telemetry/tests/ errors because it cannot locate the test files. I've confirmed they exist, however.

Seems the error is related to testing configurations, not the patch.

Possible relevance to this too?

 1:35.97 SUITE_END
 1:39.00 TEST-UNEXPECTED-FAIL | No tests collected (Not in PYTHON_UNITTEST_MANIFESTS?)
 1:39.13 TEST-UNEXPECTED-FAIL | No tests collected (Not in PYTHON_UNITTEST_MANIFESTS?)
usage: mach [-h] [--binary BINARY] [--address ADDRESS] [--emulator] [--app APP] [--app-arg APP_ARGS] [--profile PROFILE]
            [--setpref PREF=VALUE] [--preferences PREFS_FILES] [--addon ADDONS] [--repeat REPEAT] [--run-until-failure] [--testvars TESTVARS]
            [--symbols-path SYMBOLS_PATH] [--socket-timeout SOCKET_TIMEOUT] [--startup-timeout STARTUP_TIMEOUT] [--shuffle]
            [--shuffle-seed SHUFFLE_SEED] [--total-chunks TOTAL_CHUNKS] [--this-chunk THIS_CHUNK] [--server-root SERVER_ROOT]
            [--gecko-log GECKO_LOG] [--logger-name LOGGER_NAME] [--jsdebugger] [--pydebugger PYDEBUGGER] [--enable-fission]
            [--enable-webrender] [-z] [--tag TEST_TAGS] [--workspace WORKSPACE] [-v] [--emulator-binary EMULATOR_BIN] [--adb ADB_PATH]
            [--avd AVD] [--avd-home AVD_HOME] [--device DEVICE_SERIAL] [--package PACKAGE_NAME] [--log-raw LOG_RAW]
            [--log-unittest LOG_UNITTEST] [--log-xunit LOG_XUNIT] [--log-html LOG_HTML] [--log-mach LOG_MACH] [--log-tbpl LOG_TBPL]
            [--log-grouped LOG_GROUPED] [--log-raw-level LOG_RAW_LEVEL] [--log-mach-verbose] [--log-mach-level LOG_MACH_LEVEL]
            [--log-mach-buffer LOG_MACH_BUFFER] [--log-mach-screenshot] [--log-mach-no-screenshot] [--log-tbpl-compact]
            [--log-tbpl-level LOG_TBPL_LEVEL] [--log-tbpl-buffer LOG_TBPL_BUFFER]
            [tests [tests ...]]
mach: error: Test file(s) not found: toolkit/components/telemetry/tests/marionette/tests/client/test_deletion_request_ping.py toolkit/components/telemetry/tests/marionette/tests/client/test_event_ping.py toolkit/components/telemetry/tests/marionette/tests/client/test_fog_custom_ping.py toolkit/components/telemetry/tests/marionette/tests/client/test_fog_deletion_request_ping.py toolkit/components/telemetry/tests/marionette/tests/client/test_fog_user_activity.py toolkit/components/telemetry/tests/marionette/tests/client/test_main_tab_scalars.py toolkit/components/telemetry/tests/marionette/tests/client/test_search_counts_across_sessions.py toolkit/components/telemetry/tests/marionette/tests/client/test_subsession_management.py toolkit/components/telemetry/tests/marionette/tests/unit/test_ping_server_received_ping.py

I can reproduce this locally. Thank you catching this. I'll file a bug to get this fixed.

For now you can run ./mach test toolkit/components/telemetry/tests/unit and ./mach telemetry-tests-client individually.

Comment 10

[Jens Stutte [:jstutte]]

Hi Yaron, just a reminder to take a look at that patch. Thank you!

Comment 11

[Jens Stutte [:jstutte]]

Hi Randell, is this somehow related to /superseded by bug 1740335 ? Otherwise: Could you take the patch and land it? Thanks.

Comment 12

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1704133 - Removing stale probe sw.synthesized_res_count r=chutten,jstutte

Landed by jesup

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b246d6088f1c
Removing stale probe sw.synthesized_res_count r=jstutte

Comment 14

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b246d6088f1c