Closed Bug 1704141 Opened 1 month ago Closed 1 month ago

StencilXDR should deduplicate bytecode

Categories

(Core :: JavaScript Engine, defect, P1)

defect

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: tcampbell, Assigned: tcampbell)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Somewhere along the way, we lost the call to shareScriptData for the Stencil-XDR decode path. This results in missed bytecode sharing opportunities and also results in that memory being reported as heap-unclassified in about:memory.

While we don't leak memory, this is a missed memory savings and also results
in the data showing up as heap-unclassified.

Attachment #9214737 - Attachment description: WIP: Bug 1704141 - Ensure bytecode is deduplicated when decoding StencilXDR → Bug 1704141 - Ensure bytecode is deduplicated when decoding StencilXDR. r?nbp!
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/537141f364c5
Ensure bytecode is deduplicated when decoding StencilXDR. r=nbp
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.