Closed
Bug 1704141
Opened 4 years ago
Closed 4 years ago
StencilXDR should deduplicate bytecode
Categories
(Core :: JavaScript Engine, defect, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
89 Branch
| Tracking | Status | |
|---|---|---|
| firefox89 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Somewhere along the way, we lost the call to shareScriptData for the Stencil-XDR decode path. This results in missed bytecode sharing opportunities and also results in that memory being reported as heap-unclassified in about:memory.
|
Assignee | |
Comment 1•4 years ago
|
||
While we don't leak memory, this is a missed memory savings and also results
in the data showing up as heap-unclassified.
|
||
Updated•4 years ago
|
Attachment #9214737 -
Attachment description: WIP: Bug 1704141 - Ensure bytecode is deduplicated when decoding StencilXDR → Bug 1704141 - Ensure bytecode is deduplicated when decoding StencilXDR. r?nbp!
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/537141f364c5
Ensure bytecode is deduplicated when decoding StencilXDR. r=nbp
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox89:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•