1704164 - Dark mode colors set too late in activity stream startup

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Alex Thayer [:alexical] (she/her)]

On my system I see a white flash between about:blank and the fully loaded about:home. If I force the activity stream bundle js to immediately send the "LightweightTheme:Set" event, the white flash goes away. componentWillMount on ASRouterUISurface runs after first paint - we need to ensure the css variable for the background color is set prior to first paint. This feels particularly noticeable for me with the skeleton UI enabled (default on Nightly).

Comment 1

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1704164 - Apply darkmode theme to newtab before first paint r?mconley

This prevents a white flash in about:home in dark mode. Particularly obvious
with the skeleton UI enabled. I don't see a reason why we need to do this on
pageshow, if we start doing it on DOMContentLoaded, given that we listen for
theme change events anyway.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc67a43df738
Apply darkmode theme to newtab before first paint r=mconley

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/dc67a43df738