1704212 - Make XULElement.openMenu(true) work for native context menus

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task)

Description

[Markus Stange [:mstange]]

XULElement has an openMenu method which can be used to open context menu submenus: menu.openMenu(true).
We should make this method work with native menus as well, so that automated tests using it will work with both non-native and native menus.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1704212 - Make menu.openMenu(true) work for submenus of native menus. r=tnikkel

Depends on D111522

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1704212 - Move part of nsXULElement::OpenMenu into a new method called nsXULPopupManager::HideMenu. r=tnikkel

Depends on D111522

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1704212 - Remove unused return value from MenuOpened(), make MenuOpened() ignore repeated invocations, and adjust comments. r=harry

Depends on D111660

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1704212 - Add NativeMenu::OpenSubmenu. r=harry

Depends on D111661

Comment 5

[Markus Stange [:mstange]]

Attachment: Bug 1704212 - Make nsXULPopupManager::ShowMenu handle native menus, so that menu.openMenu(true) can be used in tests to support native menus. r=tnikkel

Depends on D111663

Comment 6

[Markus Stange [:mstange]]

Attachment: Bug 1704212 - Add NativeMenu::CloseSubmenu. r=harry

Depends on D111664

Comment 7

[Markus Stange [:mstange]]

Attachment: Bug 1704212 - Make nsXULPopupManager::HideMenu handle native menus, so that menu.openMenu(false) can be used in tests to support native menus. r=tnikkel

Depends on D111665

Comment 8

[Markus Stange [:mstange]]

Attachment: Bug 1704212 - Make sure we don't forget about simulated-open submenus when closing their parents, and try to enforce that submenus run their popuphidden events before their parents. r=harry

Depends on D111666

Comment 9

[Markus Stange [:mstange]]

https://treeherder.mozilla.org/jobs?repo=try&revision=f3db43fc8e6f68c917b533a9d2c2d338e7d15fd7

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21d2bf5db183
Move part of nsXULElement::OpenMenu into a new method called nsXULPopupManager::HideMenu. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/97a92ca9b16f
Remove unused return value from MenuOpened(), make MenuOpened() ignore repeated invocations, and adjust comments. r=harry
https://hg.mozilla.org/integration/autoland/rev/4fa3e5b83b9d
Add NativeMenu::OpenSubmenu. r=harry
https://hg.mozilla.org/integration/autoland/rev/8aac76367f33
Make nsXULPopupManager::ShowMenu handle native menus, so that menu.openMenu(true) can be used in tests to support native menus. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/297987c412d9
Add NativeMenu::CloseSubmenu. r=harry
https://hg.mozilla.org/integration/autoland/rev/0fc48ae0ad09
Make nsXULPopupManager::HideMenu handle native menus, so that menu.openMenu(false) can be used in tests to support native menus. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/f040df39cdc1
Make sure we don't forget about simulated-open submenus when closing their parents, and try to enforce that submenus run their popuphidden events before their parents. r=harry

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/21d2bf5db183
https://hg.mozilla.org/mozilla-central/rev/97a92ca9b16f
https://hg.mozilla.org/mozilla-central/rev/4fa3e5b83b9d
https://hg.mozilla.org/mozilla-central/rev/8aac76367f33
https://hg.mozilla.org/mozilla-central/rev/297987c412d9
https://hg.mozilla.org/mozilla-central/rev/0fc48ae0ad09
https://hg.mozilla.org/mozilla-central/rev/f040df39cdc1