Closed Bug 1704215 Opened 8 months ago Closed 8 months ago

No popuphiding/popuphidden event if a native context menu is hidden during the popupshown event

Categories

(Core :: Widget: Cocoa, defect)

All
macOS
defect

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

Details

(Whiteboard: [proton-context-menus][mac:mr1])

Attachments

(2 files)

This bug was found by toolkit/components/viewsource/test/browser/browser_contextmenu.js:

If a popupshown handler for a menupopup which is opened as a native context menu calls popup.hidePopup(), no popuphiding / popuphidden events are fired.

It looks like macOS doesn't call menuDidClose if cancelTracking is called during menuWillOpen.

Depends on D111667

Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/35ac8aaf1b31
Make MenuClosedAsync() protected. r=harry
https://hg.mozilla.org/integration/autoland/rev/1b8909a044ab
Fire popupshown asynchronously after menuWillOpen. r=harry
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.