1704215 - No popuphiding/popuphidden event if a native context menu is hidden during the popupshown event

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Markus Stange [:mstange]]

This bug was found by toolkit/components/viewsource/test/browser/browser_contextmenu.js:

If a popupshown handler for a menupopup which is opened as a native context menu calls popup.hidePopup(), no popuphiding / popuphidden events are fired.

It looks like macOS doesn't call menuDidClose if cancelTracking is called during menuWillOpen.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1704215 - Make MenuClosedAsync() protected. r=harry

Depends on D111667

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1704215 - Fire popupshown asynchronously after menuWillOpen. r=harry

Depends on D111668

Comment 3

[Markus Stange [:mstange]]

https://treeherder.mozilla.org/jobs?repo=try&revision=71c54df9083f8196ef768e0aa49705051a152324

Comment 4

[Markus Stange [:mstange]]

https://treeherder.mozilla.org/jobs?repo=try&revision=9f715a6a81e1ec7260cdeabbbc87afac40ea19be

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35ac8aaf1b31
Make MenuClosedAsync() protected. r=harry
https://hg.mozilla.org/integration/autoland/rev/1b8909a044ab
Fire popupshown asynchronously after menuWillOpen. r=harry

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/35ac8aaf1b31
https://hg.mozilla.org/mozilla-central/rev/1b8909a044ab