1704315 - create new accesskey id for processHang.button_stop.* string group to force localizers to reevaluate it (accesskey missing from label in some locals)

Status: RESOLVED FIXED

(Core :: XPConnect, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1694229 changed the text in the button to stop a script which causes Firefox to slow down from Stop It (processHang.button_stop.label) to Stop (processHang.button_stop.label2). The accesskey entity (processHang.button_stop.accessKey) remained untouched.

Some localizations picked a letter from the drop word(s) for the access key. If it's missing from the remaining word(s), it will be styled as Stop (X) (e.g. Spanish (Chile), Welsh).

Comment 1

[Francesco Lodolo [:flod]]

At this point we're better off exposing both label and access key with a new ID, at least they'll be exposed for translation together.

Comment 2

[Francesco Lodolo [:flod]]

Attachment: Bug 1704315 - Change l10n IDs for "Stop" button in process hang infobar, r=florian!

Only the label was changed in bug 1694229, causing issues with the existing access key (still used in <89 for "Stop it").
Changing both IDs to force retranslation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/419bf5e6bfaa
Change l10n IDs for "Stop" button in process hang infobar, r=florian

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/419bf5e6bfaa