1704383 - [macOS] Light strip at bottom of "About Firefox" dialog (in dark mode)

Status: RESOLVED FIXED

(Firefox :: Menus, defect, P3)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot (notice the light strip at the very bottom of dialog)

STR:

1. Open the "About Nightly" dialog. (in MacOS, click the Firefox Nightly menu, and then choose "About Nightly")
2. Drag that dialog over a dark background (to make its edges easier to see)

ACTUAL RESULTS:
The dialog itself is entirely dark, but the very bottom of the dialog has a 1px-tall strip of a light color (white or gray).

EXPECTED RESULTS:
No such strip of light color.

This is a regression, with range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a673fcbd7a067815aa8b8966e134283aae5a4e56&tochange=b1628ddad29124227e334e82e9fac863bc877e4d
--> regression from bug 1660848

I'm using a MacBook Pro (15-inch, 2019) with MacOS Big Sur, and latest Firefox Nightly.
(I have dark mode enabled in the OS settings, too, though I don't think that matters for this dialog/bug. I can reproduce in Light mode as well.)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot of expected rendering (from a build before the regression)

Here's a screenshot of the expected rendering, from a build just before the regression (taken during my mozregression run).

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: another screenshot of bug (with a bit more space around dialog to make the issue easier to see)

Comment 3

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1704383 - Remove light strip at bottom of about dialog. r=jaws

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a8281833768
Remove light strip at bottom of about dialog. r=jaws

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/6a8281833768

Comment 6

[Pascal Chevrel:pascalc]

That looks like a low risk CSS change, should we uplift to 95? Thanks

Comment 7

[Niklas Baumgardner [:niklas]]

(In reply to Pascal Chevrel:pascalc from comment #6)

That looks like a low risk CSS change, should we uplift to 95? Thanks

I don't think an uplift is needed. I was only able to repro in Nightly.