1704385 - Implement Array find from last

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Alexandre Folle de Menezes]

This proposal is currently in Stage 2.

Comment 1

[kingwl]

Attachment: Bug 1704385 - Implement {Array,%TypedArray%}.prototype.{findLast,findLastIndex}. r?yulia

Comment 2

[kingwl]

Hey folks!

I have submitted a patch to implement the proposal.
This is my first time to using Mozilla's toolchain and system.
Please let me know if I've done anything wrong or if there's anything I need to do.

Thanks!

Comment 3

[kingwl]

Seems I have missed some non-test262 tests. I'll append them soon.

Comment 4

[André Bargull [:anba]]

I've skimmed over the changes and they look really great!

Array and TypedArray properties are also tested in test_xrayToJS.xhtml.

Comment 5

[Yulia Startsev [:yulia]]

:kingwl I will assign this bug to you, thanks for taking it on! You can assign one of us as a reviewer (i am happy to take a look also) in the phabricator patch.

Comment 6

[kingwl]

Hey everyone! Sorry for pushing.

What should I do for now? Happy to follow all changes.

Thanks!

Comment 7

[Yulia Startsev [:yulia]]

can you rebase on master? If you have any issues let me know.

Comment 8

[Yulia Startsev [:yulia]]

I've reviewed the changes. A few nits -- and requires a rebase.

Comment 9

[kingwl]

Okay. In this few days.

Comment 10

[Iain Ireland [:iain]]

Attachment: Bug 1704385: Fix testcases r=tcampbell

Some of the non262 tests were failing after I rebased. It turns out that the tests themselves were wrong.

Depends on D121840

Comment 11

[Iain Ireland [:iain]]

Attachment: Bug 1704385: Add pref for Array.findLast r=mgaudet

Depends on D148329

Comment 12

[Iain Ireland [:iain]]

Attachment: Bug 1704385: Enable test262 tests for Array.findLast r=mgaudet

Depends on D148330

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f00022da18d2
Implement {Array,%TypedArray%}.prototype.{findLast,findLastIndex}. r=yulia
https://hg.mozilla.org/integration/autoland/rev/a320eb1a5edd
Fix testcases r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/4daed96c7c3f
Add pref for Array.findLast r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/05353f93e509
Enable test262 tests for Array.findLast r=mgaudet

Comment 14

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/f00022da18d2
https://hg.mozilla.org/mozilla-central/rev/a320eb1a5edd
https://hg.mozilla.org/mozilla-central/rev/4daed96c7c3f
https://hg.mozilla.org/mozilla-central/rev/05353f93e509

Comment 15

[Sebastian Zartner [:sebo]]

Yulia, I saw that this feature is implemented behind the pref javascript.options.experimental.array_find_last at the moment. Is there already a bug filed for letting it ride the trains? I couldn't find one.

Sebastian

Comment 16

[Yulia Startsev [:yulia]]

You can find the shipping bug here: https://bugzilla.mozilla.org/show_bug.cgi?id=1775026

It isn't currently riding the trains, it just went to stage 4 two weeks ago so there wasn't time to do that work yet.

Comment 17

[Hamish Willee]

FF103 docs work for this can be tracked in https://github.com/mdn/content/issues/17473

It is pretty much complete, bar reviews.