1704414 - Proton: page zoom button inside URL bar has barely visible hover feedback when Dark theme is selected

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Will]

Attachment: Proton page zoom button dark theme.png

Go to Customize > Themes and select "Dark". Change page zoom, then hover cursor over the button that appears in the URL bar. Observe there is no hover feedback. Strangely though, when I select "Default" theme, there IS hover feedback, even though nothing appears to have changed (I have Windows 10 in dark mode).

Comment 1

[Albert Scheiner [:alberts]]

Confirmed for macOS. Hover state is there for light theme, as well as the default and Alpenglow with the OS set to dark, but not the stand alone Dark theme itself.

Comment 2

[Marco Bonardo [:mak]]

Actually there is hover, it's just hard to see it due to the very dark background. Try Alpenglow that is another brighttext theme and you'll see it.

We may want to hardcode some colors for the default themes, but this is, imo, low priority.

Comment 3

[Romain Testard [:RT]]

The fact that dark theme with light OS theme gives no visible hover state whereas default theme with dark OS theme does seems a little concerning (I also see it on Win10). Should both scenarios not give the exact same appearance?

Comment 4

[Marco Bonardo [:mak]]

(In reply to Romain Testard [:RT] from comment #3)

The fact that dark theme with light OS theme gives no visible hover state whereas default theme with dark OS theme does seems a little concerning (I also see it on Win10).

Some rules apply to the default theme but don't apply to LWT themes, it's not surprising, especially for Dark that is a real theme, while Light has a bunch of tricks to make it look identical to Default. It's not given that Default and the theme give same results, for example in HC mode they don't.
Of course here there is some css rule bug, but I don't feel like the time spent on this couldn't be better spent in more critical issues.

Comment 5

[Marco Bonardo [:mak]]

Attachment: Bug 1704414 - Unfocused urlbar chiclet should look the same as Dark theme when default theme is in dark mode. r=harry

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38ffdcebd383
Unfocused urlbar chiclet should look the same as Dark theme when default theme is in dark mode. r=harry,desktop-theme-reviewers

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/38ffdcebd383

Comment 8

[Pablo]

verified fix on windows10 64bit, ubuntu 20 and MacOs 10.15 using firefox nightly 89.0a1