Enable proton modals
Categories
(Toolkit Graveyard :: Notifications and Alerts, enhancement, P1)
Tracking
(firefox89 fixed)
Tracking | Status | |
---|---|---|
firefox89 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
Attachments
(3 files, 2 obsolete files)
Per discussion with Romain, we want to enable proton modals on nightly in their current state.
Assignee | ||
Comment 1•3 years ago
|
||
Welp, let's see how bad it is: https://treeherder.mozilla.org/jobs?repo=try&revision=cabf5e40b9404ba3c80570c6195ef0f11f9cba3b
Assignee | ||
Comment 2•3 years ago
|
||
Failing tests:
browser/base/content/test/tabdialogs/browser_tabdialogbox_content_prompts.js
browser/components/places/tests/browser/browser_addBookmarkForFrame.js
annnd crashes in bug 1699844. It's quite possible that the crashes hide further test failures. :-(
Assignee | ||
Comment 3•3 years ago
|
||
I have fixes for the two tests in comment #2 but there are more places tests that are failing once I fix the addBookmarkForFrame one. Those seem largely to do with the helper that opens the bookmarks properties dialog, with context menus staying open when code was relying on the new window opening to close the menu and remove focus from it (so stray keypresses don't go there) and code being confused about whether to expect the dialog to open in a subdialog in the browser window or not. I hope to have a patch ready in the next few hours.
Assignee | ||
Comment 4•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 5•3 years ago
|
||
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/646a650576a9 fix modal tests that break with proton modals enabled, r=mak
Comment 7•3 years ago
|
||
bugherder |
Assignee | ||
Comment 8•3 years ago
|
||
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/623c1b4ecf35 work around promiseDocumentFlushed crashes in proton modal prompts, r=mconley https://hg.mozilla.org/integration/autoland/rev/16e0111f7c6d enable proton modals by default r=jaws
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 10•3 years ago
|
||
Comment 11•3 years ago
|
||
Pushed by btara@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/be83f7c46c9c fix browser_beforeunload_urlbar.js to not crash in promiseDocumentFlushed, take #2
Comment 12•3 years ago
•
|
||
Backed out changeset be83f7c46c9c (bug 1704616) for Mochitest failures in remote/cdp/test/browser/page/browser_javascriptDialog_prompt.js. CLOSED TREE
Log:
https://treeherder.mozilla.org/logviewer?job_id=336523785&repo=autoland&lineNumber=2429
https://treeherder.mozilla.org/logviewer?job_id=336531304&repo=autoland&lineNumber=19048
https://treeherder.mozilla.org/logviewer?job_id=336526531&repo=autoland&lineNumber=142963
Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=6607000204c56c89613f1637f7df93b53689907c
Backout:
https://hg.mozilla.org/integration/autoland/rev/ba0f8adbb582486a20bfc7345317805cde2f8752
Comment 13•3 years ago
|
||
Backout by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5b707acf2003 Backed out 2 changesets for Mochitest failures in remote/cdp/test/browser/page/browser_javascriptDialog_prompt.js. CLOSED TREE
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 14•3 years ago
|
||
Well, patches from 1699844 are landing now, so I pushed to try to see if that means we can flip the pref without having to work around that crash: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7593edb99ef18efc0600aaea5e92c54122594077
Assignee | ||
Comment 15•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Comment 16•3 years ago
|
||
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/43c14056afe4 handle promise rejections from promiseDocumentFlushed in case the modal window goes away, r=mconley https://hg.mozilla.org/integration/autoland/rev/7a8ac810e5a1 enable proton modals by default r=jaws
Comment 17•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/43c14056afe4
https://hg.mozilla.org/mozilla-central/rev/7a8ac810e5a1
Updated•10 months ago
|
Description
•