Closed Bug 1704651 Opened 3 years ago Closed 3 years ago

Make dom/serviceworkers/test/test_openWindow.html to pass with Fission+bfcache


(Core :: DOM: Service Workers, defect)




89 Branch
Fission Milestone M7a
Tracking Status
firefox89 --- fixed


(Reporter: smaug, Assigned: emilio)


(Blocks 1 open bug)



(2 files, 1 obsolete file)

The test seems to fail reliably with Fission+BFcache. The failure looks similar to bug 1670471.

Flags: needinfo?(emilio)

The failure wasn't in peterv's latest try run.

With fission+BFCache, we get a notification for the initial document,
and that fails the same-origin check (because about:blank isn't
same-origin with the opener) so we resolve the promise with null
rather than returning a client.

Instead, wait for the right load to arrive if the top level window
global is the initial document.

Assignee: nobody → emilio
Flags: needinfo?(emilio)

Ah, it fails on current central. Does peterv's try run have other patches on top?

Flags: needinfo?(bugs)

From Matrix:

emilio: I would expect peterv's patches just change the timing a bit so perhaps the failure didn't show up in that run

Flags: needinfo?(bugs)
Pushed by
Wait for the right load in ClientOpenWindow. r=asuth

The patch got backed out due to a problem that's pre-existing. This
listener keeps alive itself via a cyclic reference to mPromise, and
relies on the STOP notification to clean up that cycle.

nsDocLoader was firing that notification, but BrowserChild stopped
listening too early.

Flags: needinfo?(emilio)
Depends on: 1705724
Blocks: 1705724
No longer depends on: 1705724

This is enough to fix the leak though perhaps the other patch also makes

Depends on D112351

Pushed by
Trigger stop notification on discard if waiting for it. r=nika
Pushed by
Wait for the right load in ClientOpenWindow. r=asuth
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Fission Milestone: --- → M7a
Attachment #9216397 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.