Closed Bug 1704682 Opened 8 months ago Closed 8 months ago

Wrong menu state during popupshown event - got "showing", expected "open"

Categories

(Core :: Widget: Cocoa, defect)

defect

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

Details

(Whiteboard: [proton-context-menus][mac:mr1])

Attachments

(1 file)

Non-native menus set the popup state to "open" before dispatching the popupshown event.
Native menus should do the same.

This is causing a test failure in dom/html/test/browser_content_contextmenu_userinput.js.

This will cause nsXULPopupManager to change the state to "open" before the
popupshown event fires. This is consistent with non-native menus.

This was caught by dom/html/test/browser_content_contextmenu_userinput.js.

Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/4d65d12c107a
Call OnMenuOpened before dispatching the popupshown event. r=harry
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.