Closed
Bug 1704811
Opened 3 years ago
Closed 3 years ago
shouldBeIgnoredAsRedundantWithTargetAvailable is undefined instead of true for targets following the WindowGlobal lifecycle
Categories
(DevTools :: Framework, defect, P3)
DevTools
Framework
Tracking
(firefox90 fixed)
RESOLVED
FIXED
90 Branch
| Tracking | Status | |
|---|---|---|
| firefox90 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file)
The following code:
https://searchfox.org/mozilla-central/rev/3de2db87f3c9001ae478318d47a2ca3427574382/devtools/server/actors/webconsole/listeners/document-events.js#60-61
shouldBeIgnoredAsRedundantWithTargetAvailable ||
(this.targetActor.isTopLevel &&
this.targetActor.followWindowGlobalLifecycle)
includes two typos. It should be isTopLevelTarget and followWindowGlobalLifeCycle.
And this prevents having this flag set to true correctly for server side target switching.
This depends on bug 1704806 in order to cover this with a test.
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Attachment #9215449 -
Attachment description: Bug 1704811 - Set dom-loading's shouldBeIgnoredAsRedundantWithTargetAvailable to true when doing a server side target switching. → Bug 1704811 - [devtools] Set dom-loading's shouldBeIgnoredAsRedundantWithTargetAvailable to true when doing a server side target switching.
|
||
Updated•3 years ago
|
Severity: -- → S3
Priority: -- → P3
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2dffcb30365d [devtools] Set dom-loading's shouldBeIgnoredAsRedundantWithTargetAvailable to true when doing a server side target switching. r=nchevobbe
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•