1704837 - Don't synthesize events on menus in browser/components/places/tests/browser/browser_library_bookmark_pages.js

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, task)

Description

[Markus Stange [:mstange]]

This bug is for a patch that I'm moving out of bug 1704569 because landing it causes some test-verify jobs to fail with leaks.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1704837 - Don't synthesize events on menus in browser/components/places/tests/browser/browser_library_bookmark_pages.js. r=Gijs

Comment 2

[Markus Stange [:mstange]]

Job with leaks: https://treeherder.mozilla.org/logviewer?job_id=336311746&repo=try&lineNumber=8661

I can reproduce the leak locally. However, it also happens before the patch!

My hypothesis is that the leak only occurs when the test is run stand-alone. I think the test-verify job only runs this test stand-alone if the test is changed. So any patch that touches this test would probably run into the leak.

There is bug 1628028 for the leak, but it was closed because the failure hasn't been seen in 11 months. But maybe that's just because the test hasn't been touched in all that time, so the test-verify job hasn't run this test in a while.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e008bfa0c47
Don't synthesize events on menus in browser/components/places/tests/browser/browser_library_bookmark_pages.js. r=Gijs

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/3e008bfa0c47