1704853 - Skeleton UI should be disabled if using non-default UI density

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Alex Thayer [:alexical] (she/her)]

This is a temporary solution. I think we should adjust the heights of all of the relevant pieces of the skeleton UI based on this pref value. However, given that I don't know what has and has not been finalized for Proton and compact mode, I think the safest bet here is to just turn the skeleton UI off entirely if we have a non-default density.

Comment 1

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1704853 - Disable skeleton UI on non-default density r?emalysz

This is a little more than we need to disable it, but I figure we'll want to
support different UI densities in the skeleton UI long term.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95865502de4b
Disable skeleton UI on non-default density r=emalysz

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for causing bustage on AppWindow.cpp

backout: https://hg.mozilla.org/integration/autoland/rev/aa0763e9cafebae19c93abbddb0f8e7c5f1ca8d0

push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=95865502de4b095d2e575f2eb49fa105de9597f9&selectedTaskRun=DFfrcqGgSxaDhibxkk4yeA.0

failure log: https://treeherder.mozilla.org/logviewer?job_id=336716584&repo=autoland&lineNumber=23217

[task 2021-04-15T22:46:24.660Z] 22:46:24 INFO - In file included from Unified_cpp_xpfe_appshell0.cpp:2:
[task 2021-04-15T22:46:24.660Z] 22:46:24 INFO - /builds/worker/checkouts/gecko/xpfe/appshell/AppWindow.cpp:41:10: fatal error: 'nsIWindowsUIUtils.h' file not found
[task 2021-04-15T22:46:24.661Z] 22:46:24 INFO - #include "nsIWindowsUIUtils.h"
[task 2021-04-15T22:46:24.661Z] 22:46:24 INFO - ^~~~~~~~~~~~~~~~~~~~~
[task 2021-04-15T22:46:24.661Z] 22:46:24 INFO - 1 error generated.
[task 2021-04-15T22:46:24.661Z] 22:46:24 ERROR - make[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:676: Unified_cpp_xpfe_appshell0.o] Error 1

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f3747c1ddd9
Disable skeleton UI on non-default density r=emalysz

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3f3747c1ddd9