1704879 - Add support for specifying a mouse button in XULMenuPopup.activateItem

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task)

Description

[Markus Stange [:mstange]]

Our WebExtension menu items have the ability to detect the mouse button that a context menu item was clicked with: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/menus/OnClickData

This was added in bug 1469148 and is only supported in Firefox.

We have a test for this at browser/components/extensions/test/browser/browser_ext_menus_capture_secondary_click.js.

I'd like to convert this test to use the activateItem API from bug 1704206, but at the moment, activateItem does not allow specifying the mouse button.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1704879 - Allow specifying the command event's button field in XULPopupElement.activateItem. r=emilio

Depends on D111956

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1704879 - Use activateItem in browser/components/extensions/test/browser/head.js even if a button is used. r=robwu

Depends on D111979

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79945b876a1d
Allow specifying the command event's button field in XULPopupElement.activateItem. r=emilio
https://hg.mozilla.org/integration/autoland/rev/02705918c4bf
Use activateItem in browser/components/extensions/test/browser/head.js even if a button is used. r=robwu

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for conflicting with the backout of Bug 1704948

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/033cbb106695
Allow specifying the command event's button field in XULPopupElement.activateItem. r=emilio
https://hg.mozilla.org/integration/autoland/rev/c714e62ff3ea
Use activateItem in browser/components/extensions/test/browser/head.js even if a button is used. r=robwu

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/033cbb106695
https://hg.mozilla.org/mozilla-central/rev/c714e62ff3ea

Comment 7

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/8c6c70a90e78
https://hg.mozilla.org/releases/mozilla-beta/rev/a86234b27d73