1704965 - Many X11 connections created when GPU process is enabled

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Jed Davis [:jld] (away until 12-29)]

With the GPU process enabled, we use CompositorWidgetParent instead of InProcessGtkCompositorWidget; the latter is passed an X11 display, but the former opens its own. Empirically, we open at least one for each window, and causing tooltips or menus to pop up can create more. I've seen as many as 7 connections per window and I don't know if there's an upper bound.

(Note that these connections are made from the GPU process, on behalf of PCompositor{Manager,Bridge,Widget} actors from the parent process; this is unrelated to X connections from content processes.)

These should be shared somehow; ideally this would reuse the GTK display, but if that doesn't work (threading issues?) they should at least share one among themselves.

I don't know if this is strictly a blocker for using the GPU process, but for users with a lot of windows it could cause problems with the 256-client limit.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Yes, we can reuse the display connection as we enable multi-threading for X11. A simple fix which will replace XOpenDisplay() with DefaultXDisplay() may be enough, or even remove mXDisplay member and always call DefaultXDisplay() instead.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1704965 [Linux] Remove display connection from nsWindow, CompositorWidgetParent and WindowSurfaceProvider, r?jhorak

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b7eeb06193e19ce780b1f547dce196008b40027

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Try looks good.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=30e960e48157eb210a06317b75b3f5460ee1ee50

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad94106d8496
[Linux] Remove display connection from nsWindow, CompositorWidgetParent and WindowSurfaceProvider, r=jhorak

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ad94106d8496