1704978 - Get helper_hittest_overscroll_contextmenu.html to pass on Windows

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task, P3)

Description

[Botond Ballo [:botond]]

In bug 1704070 we fixed a bug, where clicking in the root scroll frame's overscroll gutter activated a browser chrome context menu, for Linux and Mac.

The test for that, helper_hittest_overscroll_contextmenu.html, is currently skipped on Windows, and would fail if it were run. This bug tracks fixing the issue and enabling the test on Windows.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

I figured out a way to solve this issue. IIUC on Windows WM_CONTEXTMENU message is sent from OS and we can tell whether the message was triggered by mouse or not just like this code. So with telling whether the last mouse up event was in overscroll gutter just like we did in bug 1704070 for Mac/Linux we can prevent opening context menu.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

There's another case we need to care to prevent opening context menu in the case of touch sceen (with touch pen?) here. I have a local fix to the case, but hasn't finished writing tests. I will handle it in another bug later.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1704978 - Remove a comment about NS_IF_RELEASE() use in nsWindow::DispatchMouseEvent. r?botond

The comment about NS_IF_RELEASE() is now useless since there's no
NS_IF_RELEASE() call.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1704978 - Prevent opening context menu in the case the user did right click in the overscroll gutter on Windows. r?botond

Depends on D155038

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6f17233ceac
Remove a comment about NS_IF_RELEASE() use in nsWindow::DispatchMouseEvent. r=botond
https://hg.mozilla.org/integration/autoland/rev/550108db5022
Prevent opening context menu in the case the user did right click in the overscroll gutter on Windows. r=botond,handyman

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c6f17233ceac
https://hg.mozilla.org/mozilla-central/rev/550108db5022