1705055 - Cleanup touch-simulator code

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

It looks like some code is unused, let's remove it

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1705055 - [devtools] Turn TouchSimulator into a class. r=jdescottes.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1705055 - [devtools] Remove unused TouchSimulator methods. r=jdescottes.

sendTouchEvent and getDelayBeforeMouseEvent are never used, so
we can safely remove them.

Depends on D112022

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1705055 - [devtools] Remove unused TouchSimulator#synthesizeNativeTouch x and y params. r=jdescottes.

Depends on D112023

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1705055 - [devtools] Remove obsolete code and mention of gaia/firefoxOS in TouchSimulator. r=jdescottes.

Depends on D112024

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1705055 - [devtools] Small TouchSimulator refactor. r=jdescottes.

• Move events outside of the class to a EVENTS_TO_HANDLE constant
• prefix contextMenuTimeout with an underscore

Depends on D112025

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f896188465a7
[devtools] Turn TouchSimulator into a class. r=jdescottes.
https://hg.mozilla.org/integration/autoland/rev/85c5766c5332
[devtools] Remove unused TouchSimulator methods. r=jdescottes.
https://hg.mozilla.org/integration/autoland/rev/29fdbf6c5c8b
[devtools] Remove unused TouchSimulator#synthesizeNativeTouch x and y params. r=jdescottes.
https://hg.mozilla.org/integration/autoland/rev/1e99b4709623
[devtools] Remove obsolete code and mention of gaia/firefoxOS in TouchSimulator. r=jdescottes.
https://hg.mozilla.org/integration/autoland/rev/a9bf3a2ebb1e
[devtools] Small TouchSimulator refactor. r=jdescottes.

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f896188465a7
https://hg.mozilla.org/mozilla-central/rev/85c5766c5332
https://hg.mozilla.org/mozilla-central/rev/29fdbf6c5c8b
https://hg.mozilla.org/mozilla-central/rev/1e99b4709623
https://hg.mozilla.org/mozilla-central/rev/a9bf3a2ebb1e