Private Browsing not respected for search suggestions
Categories
(Fenix :: General, defect)
Tracking
(firefox88 wontfix, firefox89 verified, firefox90 fixed)
People
(Reporter: jwkbugzilla, Assigned: sebastian)
Details
(Keywords: csectype-disclosure, privacy, sec-moderate, Whiteboard: [adv-main89+])
Attachments
(1 file)
303 bytes,
text/plain
|
Details |
The problematic code can be seen here:
The request retrieving search suggestions does not respect Private Browsing mode. While Fenix doesn’t have search suggestions enabled by default in Private Browsing and warns about the impact (everything typed into address bar sent to search provider), this is still unnecessary. Once a search is accepted, this allows search providers (by default Google) to match the regular search session to the private one.
The issue can be confirmed by debugging the network traffic of the main process: search suggestions always send the cookies from the regular session, regardless of whether the user is currently in a private tab.
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
I'll take a stab at this.
Updated•3 years ago
|
Comment 3•3 years ago
|
||
Is this something we should consider backporting to AC75/Fenix89?
Assignee | ||
Comment 4•3 years ago
|
||
Uplifting to AC75: https://github.com/mozilla-mobile/android-components/pull/10274
Assignee | ||
Comment 6•3 years ago
|
||
Fenix PR with AC version bump and patch uplift:
https://github.com/mozilla-mobile/fenix/pull/19537
Comment 7•3 years ago
|
||
This merged for Fenix 89.0.0-beta.8 also.
https://github.com/mozilla-mobile/fenix/commit/2c2cec6ea17ab3b8816e2031a9f1394c79280478
Comment 8•3 years ago
|
||
Verified as fixed on Fenix 89.0.0-beta8 and 9 with Google Pixel 4 XL (Android 11).
Note that the Allow search suggestions in PB prompt was displayed when first time typing in the URL bar.
Updated•3 years ago
|
Updated•3 years ago
|
Comment 9•3 years ago
|
||
Updated•3 years ago
|
Updated•3 years ago
|
Updated•2 years ago
|
Description
•