1705105 - Update bookmarks folder context menu per new UX spec

Status: VERIFIED FIXED

(Firefox :: Menus, enhancement)

Description

[:Gijs (he/him)]

UX have suggested we could relabel:

Edit... --> "Rename Folder..."
Remove --> "Remove Folder"

and move "Sort By Name" up to this section.

Comment 1

[Bernard Igiri]

Attachment: Screen Shot 2021-04-14 at 6.42.32 PM.png

Like this?

Comment 2

[:Gijs (he/him)]

(In reply to Bernard Igiri from comment #1)

Created attachment 9215922 [details]
Screen Shot 2021-04-14 at 6.42.32 PM.png

Like this?

Yes, see https://docs.google.com/presentation/d/1-D_7o2Kn34y0sli6GeemQAsTkZywHuX7d-wuG8qtovc/edit?ts=606bb718#slide=id.gcf3d12ab1f_0_12 for context. You probably want to ask for review from :mak - this context menu (ie the places one) can be tricky because it is also used in the library window and the bookmarks and history sidebar, so we would need to be careful about when we show the new strings / ordering to make sure the labels make sense.

Comment 3

[Bernard Igiri]

Attachment: Bug 1705105 - Update bookmarks folder context menu r=mak

Changed the text on the edit and delete folder buttons and moved position of the Sort By Name menu item.

Comment 4

[Bernard Igiri]

I just attached a WIP patch I could use feeback on it. Is this the right direction? I know I have to fix the placesContext_sortSeparator separator and look for affected javascript code.

Comment 5

[Marco Bonardo [:mak]]

Honestly, I'm not enthusiastic about adding even more special cases to this menu, why do we have to name each specific selection differently? I'm personally already having difficulties finding the options in the menu, now that they are all named differently.
Not even the operating systems are doing this for files, images, folders, and so on...
To be clear, I totally understand you're executing a plan, thus I'm not really complaining to you, just ranting.

That said, let me look at the patch, I think the approach is ok, time to check the details.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93aa1978e8b1
Update bookmarks folder context menu r=fluent-reviewers,mak,flod

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/93aa1978e8b1

Comment 8

[Bogdan Maris, Desktop Test Engineering]

Verified that the context for bookmarks folder is updated based on the new UX (comment 0) doc across platforms.