Closed Bug 1705141 Opened 3 years ago Closed 2 years ago

Implement the imperative slotting API

Categories

(Core :: DOM: Core & HTML, enhancement)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox92 --- fixed

People

(Reporter: masonfreed, Assigned: sefeng)

References

(Blocks 2 open bugs)

Details

(Keywords: dev-doc-needed)

Attachments

(6 files)

WIP: Bug 1705141, wip
48 bytes, text/x-phabricator-request
Details | Review
Bug 1705141 - Update tests ini settings for HTMLSlotElement::Assign r=smaug
48 bytes, text/x-phabricator-request
Details | Review
Bug 1705141 - Update imperative slotting API tests r=smaug
48 bytes, text/x-phabricator-request
Details | Review
Bug 1705141 - Move the usage of SlotAssignedNodeChanged into (Insert|Append|Remove)AssignedNode functions r=smaug
48 bytes, text/x-phabricator-request
Details | Review
Bug 1705141 - Implement imperative slotting API r=smaug
48 bytes, text/x-phabricator-request
Details | Review
Bug 1705141 - Fix an imperative slotting API test r=smaug
48 bytes, text/x-phabricator-request
Details | Review

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4469.4 Safari/537.36

Steps to reproduce:

Tracking bug to implement the imperative slotting API.

Discussion: https://github.com/whatwg/html/issues/3534
HTML PR: https://github.com/whatwg/html/pull/6561
DOM PR: https://github.com/whatwg/dom/pull/966

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Core & HTML' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → DOM: Core & HTML
Product: Firefox → Core
Status: UNCONFIRMED → NEW
Ever confirmed: true
Blocks: shadowdom
Severity: -- → N/A
Blocks: dom
Assignee: nobody → bugs

Will finish Olli's WIP patch.

Assignee: bugs → sefeng

Depends on D119441

According to our current usage, I don't see a case where we need to call
SlotAssignedNodeChanged without acutally moving the node. So this patch
just simpifies that behaviour.

Depends on D119442

Depends on D119443

Attachment #9230346 - Attachment description: WIP: Bug 1705141 - Update idl related settings for HTMLSlotElement::Assign → Bug 1705141 - Update idl related settings for HTMLSlotElement::Assign
Attachment #9230347 - Attachment description: WIP: Bug 1705141 - Update imperative slotting API tests - Added a new test to ensure the assign slottables step is done in tree order - Added a new assertion to a test → Bug 1705141 - Update imperative slotting API tests - Added a new test to ensure the assign slottables step is done in tree order - Added a new assertion to a test
Attachment #9230348 - Attachment description: WIP: Bug 1705141 - Move the usage of SlotAssignedNodeChanged into (Insert|Append|Remove)AssignedNode functions → Bug 1705141 - Move the usage of SlotAssignedNodeChanged into (Insert|Append|Remove)AssignedNode functions
Attachment #9230349 - Attachment description: WIP: Bug 1705141 - Implement imperative slotting API → Bug 1705141 - Implement imperative slotting API

When the manual assigned node is moved to its original root, it should
be assigned again.

Attachment #9230347 - Attachment description: Bug 1705141 - Update imperative slotting API tests - Added a new test to ensure the assign slottables step is done in tree order - Added a new assertion to a test → Bug 1705141 - Update imperative slotting API tests - Added a new test to ensure the assign slottables step is done in tree order - Added a new assertion to a test r=smaug
Attachment #9230346 - Attachment description: Bug 1705141 - Update idl related settings for HTMLSlotElement::Assign → Bug 1705141 - Update tests ini settings for HTMLSlotElement::Assign r=smaug
Attachment #9230348 - Attachment description: Bug 1705141 - Move the usage of SlotAssignedNodeChanged into (Insert|Append|Remove)AssignedNode functions → Bug 1705141 - Move the usage of SlotAssignedNodeChanged into (Insert|Append|Remove)AssignedNode functions r=smaug
Attachment #9230349 - Attachment description: Bug 1705141 - Implement imperative slotting API → Bug 1705141 - Implement imperative slotting API r=smaug
Attachment #9230349 - Attachment description: Bug 1705141 - Implement imperative slotting API r=smaug → WIP: Bug 1705141 - Implement imperative slotting API r=smaug
Attachment #9230349 - Attachment description: WIP: Bug 1705141 - Implement imperative slotting API r=smaug → Bug 1705141 - Implement imperative slotting API r=smaug
Attachment #9230347 - Attachment description: Bug 1705141 - Update imperative slotting API tests - Added a new test to ensure the assign slottables step is done in tree order - Added a new assertion to a test r=smaug → Bug 1705141 - Update imperative slotting API tests r=smaug
Pushed by sefeng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/880b74325298
Fix an imperative slotting API test r=smaug
https://hg.mozilla.org/integration/autoland/rev/f3f3f0a6ac0c
Update imperative slotting API tests r=smaug
https://hg.mozilla.org/integration/autoland/rev/1f8746b344c1
Update tests ini settings for HTMLSlotElement::Assign r=smaug
https://hg.mozilla.org/integration/autoland/rev/48efa42e544e
Move the usage of SlotAssignedNodeChanged into (Insert|Append|Remove)AssignedNode functions r=smaug
https://hg.mozilla.org/integration/autoland/rev/0a87a26cc1b1
Implement imperative slotting API r=smaug,emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/29719 for changes under testing/web-platform/tests
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.